Re: [Qemu-devel] [PATCH v2 for-2.10 1/8] chardev: Basic support for TN3270

[Marc-André Lureau]

On Wed, May 3, 2017 at 3:32 PM Cornelia Huck <address@hidden>
wrote:

> On Fri, 28 Apr 2017 14:17:12 +0000
> Marc-André Lureau <address@hidden> wrote:
>
> > Hi
> >
> > On Fri, Apr 7, 2017 at 3:19 PM Cornelia Huck <address@hidden>
> > wrote:
> >
> > > From: Jing Liu <address@hidden>
> > >
> > > This introduces basic support for TN3270, which needs to negotiate
> > > three Telnet options during handshake:
> > >   - End of Record
> > >   - Binary Transmission
> > >   - Terminal-Type
> > >
> > > As a basic implementation, this simply ignores NOP and Interrupt
> > > Process(IP) commands. More work should be done for them later.
> > >
> > > For more details, please refer to RFC 854 and 1576.
> > >
> > Signed-off-by: Jing Liu <address@hidden>
> > > Signed-off-by: Yang Chen <address@hidden>
> > > Reviewed-by: QingFeng Hao <address@hidden>
> > > Acked-by: Dong Jia Shi <address@hidden>
> > > Signed-off-by: Cornelia Huck <address@hidden>
> > > ---
> > >  chardev/char-socket.c | 76
> > > +++++++++++++++++++++++++++++++++++++--------------
> > >  chardev/char.c        | 11 ++++++--
> > >  include/sysemu/char.h |  8 ++++++
> > >  qapi-schema.json      |  3 ++
> > >  4 files changed, 76 insertions(+), 22 deletions(-)
>
> > > diff --git a/include/sysemu/char.h b/include/sysemu/char.h
> > > index 450881d42c..f6d5cd0c9b 100644
> > > --- a/include/sysemu/char.h
> > > +++ b/include/sysemu/char.h
> > > @@ -7,6 +7,14 @@
> > >  #include "qemu/bitmap.h"
> > >  #include "qom/object.h"
> > >
> > > +#define IAC_EOR 239
> > > +#define IAC_SE 240
> > > +#define IAC_NOP 241
> > > +#define IAC_BREAK 243
> > > +#define IAC_IP 244
> > > +#define IAC_SB 250
> > > +#define IAC 255
> > > +
> > >
> >
> > Those define are exposed because of a later patch.
> >
> > (I have pending patches to have a char/char-socket.h and friends where
> this
> > should fit, but for now it's fine)
>
> OK. FWIW, I plan to send a pull req for 3270 this week.
>
> >
> > Patch looks good to me, basic testing done
>
> Cool, thanks. May I count that as an ack? :)
>

yep
Reviewed-by: Marc-André Lureau <address@hidden>
-- 
Marc-André Lureau