Re: [Qemu-devel] [PATCH v5++ 1/3] tcg/mips: implement goto_ptr

[Richard Henderson]

On 04/30/2017 04:52 PM, Aurelien Jarno wrote:
> +        /* jmp to the given host address (could be epilogue) */
> +        tcg_out_opc_reg(s, OPC_JR, 0, a0, 0);
> +        tcg_out_nop(s);

Any particular reason not to do the zeroing in the delay slot...

> +    s->code_gen_epilogue = s->code_ptr;
> +    tcg_out_mov(s, TCG_TYPE_REG, TCG_REG_V0, TCG_REG_ZERO);

... instead of here?


r~