[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] Deprecate '-enable-kvm' and '-enable-hax' in fa
From: |
Thomas Huth |
Subject: |
Re: [Qemu-devel] [PATCH] Deprecate '-enable-kvm' and '-enable-hax' in favour of '-accel' |
Date: |
Tue, 2 May 2017 18:19:15 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 |
On 02.05.2017 18:08, Paolo Bonzini wrote:
[...]
>>> So the first lesson should be "no deprecation
>>> without documentation" (any reference to 18th century political slogans
>>> is purely coincidential :)).
>> Would you accept my patch if I'd remove the hunks for vl.c, i.e. a patch
>> that just updates the documentation?
>
> No, updating the documentation is pointless if you don't improve it at
> the same time.
>
> I don't like writing it so often, especially to someone who is a
> relatively experienced contributor, but the common word in all these
> reviews is "pointless". What is the *purpose* of this work?
Marking the -enable-xxx options in the documentation as deprecated would
maybe at least prevent that we end up with more
-enable-mynewcoolaccelerator options in the future, like we did with
-enable-hax now.
But ok, I got the message, and I'll shut up here now. Sorry for wasting
your time.
Thomas
- Re: [Qemu-devel] [PATCH] Deprecate '-enable-kvm' and '-enable-hax' in favour of '-accel', (continued)
- Re: [Qemu-devel] [PATCH] Deprecate '-enable-kvm' and '-enable-hax' in favour of '-accel', Thomas Huth, 2017/05/02
- Re: [Qemu-devel] [PATCH] Deprecate '-enable-kvm' and '-enable-hax' in favour of '-accel', Thomas Huth, 2017/05/02
- Re: [Qemu-devel] [PATCH] Deprecate '-enable-kvm' and '-enable-hax' in favour of '-accel', Daniel P. Berrange, 2017/05/02
- Re: [Qemu-devel] [PATCH] Deprecate '-enable-kvm' and '-enable-hax' in favour of '-accel', Daniel P. Berrange, 2017/05/02
- Re: [Qemu-devel] [PATCH] Deprecate '-enable-kvm' and '-enable-hax' in favour of '-accel', Thomas Huth, 2017/05/02
- Re: [Qemu-devel] [PATCH] Deprecate '-enable-kvm' and '-enable-hax' in favour of '-accel', Paolo Bonzini, 2017/05/02
- Re: [Qemu-devel] [PATCH] Deprecate '-enable-kvm' and '-enable-hax' in favour of '-accel', Markus Armbruster, 2017/05/02
- Re: [Qemu-devel] [PATCH] Deprecate '-enable-kvm' and '-enable-hax' in favour of '-accel', Paolo Bonzini, 2017/05/02
- Re: [Qemu-devel] [PATCH] Deprecate '-enable-kvm' and '-enable-hax' in favour of '-accel', Thomas Huth, 2017/05/02
- Re: [Qemu-devel] [PATCH] Deprecate '-enable-kvm' and '-enable-hax' in favour of '-accel', Paolo Bonzini, 2017/05/02
- Re: [Qemu-devel] [PATCH] Deprecate '-enable-kvm' and '-enable-hax' in favour of '-accel',
Thomas Huth <=
- Re: [Qemu-devel] [PATCH] Deprecate '-enable-kvm' and '-enable-hax' in favour of '-accel', Paolo Bonzini, 2017/05/02
- Re: [Qemu-devel] [PATCH] Deprecate '-enable-kvm' and '-enable-hax' in favour of '-accel', Markus Armbruster, 2017/05/03
- Re: [Qemu-devel] [PATCH] Deprecate '-enable-kvm' and '-enable-hax' in favour of '-accel', Christian Borntraeger, 2017/05/02