[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH RFC] dist: create separate dist with bundled rom
From: |
Daniel P. Berrange |
Subject: |
Re: [Qemu-devel] [PATCH RFC] dist: create separate dist with bundled roms/libs |
Date: |
Tue, 2 May 2017 15:02:52 +0100 |
User-agent: |
Mutt/1.7.1 (2016-10-04) |
On Tue, May 02, 2017 at 02:24:56PM +0100, Stefan Hajnoczi wrote:
> On Thu, Apr 20, 2017 at 01:16:39PM +0100, Daniel P. Berrange wrote:
> > The qemu-XXXX.tar.bz2 currently contains bundled copies of the pixman
> > and dtc codebases, as well as pre-built ROM binaries and their sources.
> >
> > Many OS distros want to build & ship ROMs separately to ensure license
> > compliance. Similarly they'll build pixman/dtc code independantly to
> > allow sharing with the rest of the distro. Thus they'll never use these
> > bundled files. A further complication is that these bundled files create
> > extra auditing work for distros when applying for export compliance,
> > particularly when the bundled files contain crypto code. This burden
> > applies merely by having the files in the tar.bz2, even if they're not
> > built into the binaries. If we ever want to include UEFI ROMs for x86
> > or AArch64, then the size of the QEMU dist will increase significantly
> > more.
> >
> > The bundled ROMs though are fairly useful to end-users who are building
> > QEMU themselves and don't want to worry about figuring out the right
> > BIOS bits to build manually, so they shouldn't be dropped entirely.
> >
> > This change thus alters 'make dist' to generate two release archives
> >
> > - qemu-XXX.tar.bz2 - minimal archive with only QEMU source code
> > - qemu-bundled-XXX.tar.bz2 - QEMU source, plus bundled ROMs & libs
> >
> > NB1, as it stands this change breaks "make install" since that assumes
> > existance of the pre-built ROMs in tree.
>
> It would be good to fix this so that a minimal dist can build and
> install successfully.
Of course, I simply didn't want to sink time into it until we had a
little discussion about whether this is even the right direction
to take.
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|