qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 01/16] qio: create new qio_channel_write_all


From: Juan Quintela
Subject: Re: [Qemu-devel] [PATCH 01/16] qio: create new qio_channel_write_all
Date: Thu, 27 Apr 2017 10:19:17 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux)

"Daniel P. Berrange" <address@hidden> wrote:
> On Mon, Mar 13, 2017 at 01:44:19PM +0100, Juan Quintela wrote:
>> The function waits until it is able to write the full iov.
>> 
>
> Can you make sure this is covered in the test suite. Something added
> or changed in tests/io-channel-helpers.c should be sufficient. eg use
> it from test_io_thread_writer() when applicable

Ok, I integreted together the two patches, and added tests for:

qio_channel_writev - qio_channel_readv
qio_channel_writev_all - qio_channel_readv
qio_channel_writev - qio_channel_readv_all
qio_channel_writev_all - qio_channel_readv_all

I did it only for test-io-channel-buffer.c, though.

Thanks, Juan.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]