[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 3/3] tests: Add a tester for HMP commands
From: |
Thomas Huth |
Subject: |
Re: [Qemu-devel] [PATCH v3 3/3] tests: Add a tester for HMP commands |
Date: |
Thu, 27 Apr 2017 06:50:19 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 |
On 25.04.2017 15:22, Eric Blake wrote:
> On 04/25/2017 12:16 AM, Thomas Huth wrote:
>> HMP commands do not get any automatic testing yet, so on certain
>> QEMU machines, some HMP commands were causing crashes in the past.
>> Thus we should test HMP commands in our test suite, too, to avoid
>> that such problems creep in again in the future.
>>
>> Signed-off-by: Thomas Huth <address@hidden>
>> ---
>> v3:
>> - Fixed the stupid "!strcmp() == 0" problem
>
> That's why libvirt prefers the use of a STREQ() macro (it's easier to
> read STREQ(a,b) than it is to remember if !strcmp(a,b) has the right
> semantics). But switching the code base to use such a nice wrapper
> would be a task for Coccinelle, if we wanted it.
I just saw that glib seems also to have a g_str_equal() function ... I
guess we could use that in QEMU instead. I'll try to remember that for
future code that I write ...
Thomas
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PULL 1/4] hmp: gpa2hva and gpa2hpa hostaddr command, (continued)
- [Qemu-devel] [PULL 1/4] hmp: gpa2hva and gpa2hpa hostaddr command, Dr. David Alan Gilbert (git), 2017/04/24
- [Qemu-devel] [PULL 2/4] libqtest: Ignore QMP events when parsing the response for HMP commands, Dr. David Alan Gilbert (git), 2017/04/24
- [Qemu-devel] [PULL 4/4] tests: Add a tester for HMP commands, Dr. David Alan Gilbert (git), 2017/04/24
- [Qemu-devel] [PULL 3/4] libqtest: Add a generic function to run a callback function for every machine, Dr. David Alan Gilbert (git), 2017/04/24
- Re: [Qemu-devel] [PULL 0/4] hmp queue, Peter Maydell, 2017/04/24
[Qemu-devel] [PULL 0/4] hmp queue, Dr. David Alan Gilbert (git), 2017/04/25
- [Qemu-devel] [PULL 2/4] libqtest: Ignore QMP events when parsing the response for HMP commands, Dr. David Alan Gilbert (git), 2017/04/25
- [Qemu-devel] [PULL 1/4] hmp: gpa2hva and gpa2hpa hostaddr command, Dr. David Alan Gilbert (git), 2017/04/25
- [Qemu-devel] [PULL 3/4] libqtest: Add a generic function to run a callback function for every machine, Dr. David Alan Gilbert (git), 2017/04/25
- [Qemu-devel] [PULL 4/4] tests: Add a tester for HMP commands, Dr. David Alan Gilbert (git), 2017/04/25
- Re: [Qemu-devel] [PULL 0/4] hmp queue, Peter Maydell, 2017/04/25