Re: [Qemu-devel] [PULL 8/8] qga: Add `guest-get-timezone` command

[Daniel P. Berrange]

On Tue, Apr 25, 2017 at 06:04:41PM -0500, Michael Roth wrote:
> From: Vinzenz Feenstra <address@hidden>
> 
> Adds a new command `guest-get-timezone` reporting the currently
> configured timezone on the system. The information on what timezone is
> currently is configured is useful in case of Windows VMs where the
> offset of the hardware clock is required to have the same offset. This
> can be used for management systems like `oVirt` to detect the timezone
> difference and warn administrators of the misconfiguration.

> +GuestTimezone *qmp_guest_get_timezone(Error **errp)
> +{

> +    name = g_time_zone_get_abbreviation(tz, intv);

[snip]

> +##
> +# @GuestTimezone:
> +#
> +# @zone:    Timezone name

This isn't clearly documented in glib, but it looks like the time zone
names are *different* when glib is run on POSIX vs Win32 platforms.

Do we really want to expose something in QAPI that is going to have
different semantics depending on the guest OS the agent runs in ?

> +# @offset:  Offset to UTC in seconds, negative numbers for time zones west of
> +#           GMT, positive numbers for east
> +#
> +# Since: 2.10
> +##
> +{ 'struct': 'GuestTimezone',
> +  'data':   { '*zone': 'str', 'offset': 'int' } }

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|