Re: [Qemu-devel] [PATCH 6/6] migration: Pass Error ** argument to {save, load}_vmstate

[Laurent Vivier]

On 25/04/2017 12:24, Juan Quintela wrote:
> This way we use the "normal" way of printing errors for hmp commands.
> 
> --
> Paolo suggestion

"Suggested-by" tag?

> 
> Signed-off-by: Juan Quintela <address@hidden>
> ---
>  hmp.c                    |  9 +++++++--
>  include/sysemu/sysemu.h  |  4 ++--
>  migration/savevm.c       | 51 
> ++++++++++++++++++++++++------------------------
>  replay/replay-snapshot.c |  6 ++++--
>  vl.c                     |  4 +++-
>  5 files changed, 41 insertions(+), 33 deletions(-)
> 
...
> diff --git a/replay/replay-snapshot.c b/replay/replay-snapshot.c
> index 8cced46..fdc4353 100644
> --- a/replay/replay-snapshot.c
> +++ b/replay/replay-snapshot.c
> @@ -62,14 +62,16 @@ void replay_vmstate_register(void)
>  
>  void replay_vmstate_init(void)
>  {
> +    Error *err = NULL;
> +
>      if (replay_snapshot) {
>          if (replay_mode == REPLAY_MODE_RECORD) {
> -            if (save_vmstate(replay_snapshot) != 0) {
> +            if (save_vmstate(replay_snapshot, &err) != 0) {
>                  error_report("Could not create snapshot for icount record");
>                  exit(1);
>              }
>          } else if (replay_mode == REPLAY_MODE_PLAY) {
> -            if (load_vmstate(replay_snapshot) != 0) {
> +            if (load_vmstate(replay_snapshot, &err) != 0) {
>                  error_report("Could not load snapshot for icount replay");
>                  exit(1);
>              }

You can use "&error_fatal" in these cases.

Thanks,
Laurent