[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 42/65] ram: We don't need MigrationState parameter an
From: |
Juan Quintela |
Subject: |
[Qemu-devel] [PULL 42/65] ram: We don't need MigrationState parameter anymore |
Date: |
Fri, 21 Apr 2017 13:56:23 +0200 |
Remove it from callers and callees.
Signed-off-by: Juan Quintela <address@hidden>
Reviewed-by: Dr. David Alan Gilbert <address@hidden>
Reviewed-by: Peter Xu <address@hidden>
---
migration/ram.c | 27 ++++++++++-----------------
1 file changed, 10 insertions(+), 17 deletions(-)
diff --git a/migration/ram.c b/migration/ram.c
index 289d7eb..fe01e7b 100644
--- a/migration/ram.c
+++ b/migration/ram.c
@@ -794,13 +794,11 @@ static void ram_release_pages(const char *rbname,
uint64_t offset, int pages)
* if xbzrle noticed the page was the same.
*
* @rs: current RAM state
- * @ms: current migration state
* @block: block that contains the page we want to send
* @offset: offset inside the block for the page
* @last_stage: if we are at the completion stage
*/
-static int ram_save_page(RAMState *rs, MigrationState *ms,
- PageSearchStatus *pss, bool last_stage)
+static int ram_save_page(RAMState *rs, PageSearchStatus *pss, bool last_stage)
{
int pages = -1;
uint64_t bytes_xmit;
@@ -974,13 +972,12 @@ static int compress_page_with_multi_thread(RAMState *rs,
RAMBlock *block,
* Returns the number of pages written.
*
* @rs: current RAM state
- * @ms: current migration state
* @block: block that contains the page we want to send
* @offset: offset inside the block for the page
* @last_stage: if we are at the completion stage
*/
-static int ram_save_compressed_page(RAMState *rs, MigrationState *ms,
- PageSearchStatus *pss, bool last_stage)
+static int ram_save_compressed_page(RAMState *rs, PageSearchStatus *pss,
+ bool last_stage)
{
int pages = -1;
uint64_t bytes_xmit = 0;
@@ -1311,10 +1308,8 @@ err:
* @last_stage: if we are at the completion stage
* @dirty_ram_abs: address of the start of the dirty page in ram_addr_t space
*/
-static int ram_save_target_page(RAMState *rs, MigrationState *ms,
- PageSearchStatus *pss,
- bool last_stage,
- ram_addr_t dirty_ram_abs)
+static int ram_save_target_page(RAMState *rs, PageSearchStatus *pss,
+ bool last_stage, ram_addr_t dirty_ram_abs)
{
int res = 0;
@@ -1329,9 +1324,9 @@ static int ram_save_target_page(RAMState *rs,
MigrationState *ms,
if (migrate_use_compression()
&& (rs->ram_bulk_stage || !migrate_use_xbzrle())) {
- res = ram_save_compressed_page(rs, ms, pss, last_stage);
+ res = ram_save_compressed_page(rs, pss, last_stage);
} else {
- res = ram_save_page(rs, ms, pss, last_stage);
+ res = ram_save_page(rs, pss, last_stage);
}
if (res < 0) {
@@ -1370,8 +1365,7 @@ static int ram_save_target_page(RAMState *rs,
MigrationState *ms,
* @last_stage: if we are at the completion stage
* @dirty_ram_abs: Address of the start of the dirty page in ram_addr_t space
*/
-static int ram_save_host_page(RAMState *rs, MigrationState *ms,
- PageSearchStatus *pss,
+static int ram_save_host_page(RAMState *rs, PageSearchStatus *pss,
bool last_stage,
ram_addr_t dirty_ram_abs)
{
@@ -1379,7 +1373,7 @@ static int ram_save_host_page(RAMState *rs,
MigrationState *ms,
size_t pagesize = qemu_ram_pagesize(pss->block);
do {
- tmppages = ram_save_target_page(rs, ms, pss, last_stage,
dirty_ram_abs);
+ tmppages = ram_save_target_page(rs, pss, last_stage, dirty_ram_abs);
if (tmppages < 0) {
return tmppages;
}
@@ -1411,7 +1405,6 @@ static int ram_save_host_page(RAMState *rs,
MigrationState *ms,
static int ram_find_and_save_block(RAMState *rs, bool last_stage)
{
PageSearchStatus pss;
- MigrationState *ms = migrate_get_current();
int pages = 0;
bool again, found;
ram_addr_t dirty_ram_abs; /* Address of the start of the dirty page in
@@ -1440,7 +1433,7 @@ static int ram_find_and_save_block(RAMState *rs, bool
last_stage)
}
if (found) {
- pages = ram_save_host_page(rs, ms, &pss, last_stage,
dirty_ram_abs);
+ pages = ram_save_host_page(rs, &pss, last_stage, dirty_ram_abs);
}
} while (!pages && again);
--
2.9.3
- [Qemu-devel] [PULL 32/65] ram: Move last_req_rb to RAMState, (continued)
- [Qemu-devel] [PULL 32/65] ram: Move last_req_rb to RAMState, Juan Quintela, 2017/04/21
- [Qemu-devel] [PULL 33/65] ram: Move src_page_req* to RAMState, Juan Quintela, 2017/04/21
- [Qemu-devel] [PULL 34/65] ram: Create ram_dirty_sync_count(), Juan Quintela, 2017/04/21
- [Qemu-devel] [PULL 35/65] ram: Remove dirty_bytes_rate, Juan Quintela, 2017/04/21
- [Qemu-devel] [PULL 36/65] ram: Move dirty_pages_rate to RAMState, Juan Quintela, 2017/04/21
- [Qemu-devel] [PULL 37/65] ram: Move postcopy_requests into RAMState, Juan Quintela, 2017/04/21
- [Qemu-devel] [PULL 38/65] ram: Add QEMUFile to RAMState, Juan Quintela, 2017/04/21
- [Qemu-devel] [PULL 39/65] ram: Move QEMUFile into RAMState, Juan Quintela, 2017/04/21
- [Qemu-devel] [PULL 40/65] ram: Remove compression_switch and inline its logic, Juan Quintela, 2017/04/21
- [Qemu-devel] [PULL 41/65] migration: Remove MigrationState from migration_in_postcopy, Juan Quintela, 2017/04/21
- [Qemu-devel] [PULL 42/65] ram: We don't need MigrationState parameter anymore,
Juan Quintela <=
- [Qemu-devel] [PULL 43/65] ram: Rename qemu_target_page_bits() to qemu_target_page_size(), Juan Quintela, 2017/04/21
- [Qemu-devel] [PULL 44/65] ram: Add page-size to output in 'info migrate', Juan Quintela, 2017/04/21
- [Qemu-devel] [PULL 45/65] ram: Pass RAMBlock to bitmap_sync, Juan Quintela, 2017/04/21
- [Qemu-devel] [PULL 46/65] ram: ram_discard_range() don't use the mis parameter, Juan Quintela, 2017/04/21
- [Qemu-devel] [PULL 47/65] ram: reorganize last_sent_block, Juan Quintela, 2017/04/21
- [Qemu-devel] [PULL 48/65] ram: Use page number instead of an address for the bitmap operations, Juan Quintela, 2017/04/21
- [Qemu-devel] [PULL 49/65] ram: Remember last_page instead of last_offset, Juan Quintela, 2017/04/21
- [Qemu-devel] [PULL 50/65] ram: Change offset field in PageSearchStatus to page, Juan Quintela, 2017/04/21
- [Qemu-devel] [PULL 52/65] ram: rename last_ram_offset() last_ram_pages(), Juan Quintela, 2017/04/21
- [Qemu-devel] [PULL 54/65] migration: Remove MigrationState parameter from migration_is_idle(), Juan Quintela, 2017/04/21