[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2] iotests: 109: Filter out "len" of failed job
From: |
Fam Zheng |
Subject: |
Re: [Qemu-devel] [PATCH v2] iotests: 109: Filter out "len" of failed jobs |
Date: |
Thu, 20 Apr 2017 08:53:22 +0800 |
User-agent: |
Mutt/1.8.0 (2017-02-23) |
On Wed, 04/19 18:38, Paolo Bonzini wrote:
>
>
> On 19/04/2017 11:17, Fam Zheng wrote:
> > Mirror calculates job len from current I/O progress:
> >
> > s->common.len = s->common.offset +
> > (cnt + s->sectors_in_flight) * BDRV_SECTOR_SIZE;
> >
> > The final "len" of a failed mirror job in iotests 109 depends on the
> > subtle timing of the completion of read and write issued in the first
> > mirror iteration. The second iteration may or may not have run when the
> > I/O error happens, resulting in non-deterministic output of the
> > BLOCK_JOB_COMPLETED event text.
> >
> > Similar to what was done in a752e4786, filter out the field to make the
> > test robust.
>
> There are more occurrences:
Yes. I'll convert them too..
Fam