[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH for-2.9-rc5 v3] block: Drain BH in bdrv_drained_
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [Qemu-devel] [PATCH for-2.9-rc5 v3] block: Drain BH in bdrv_drained_begin |
|
Date: |
Tue, 18 Apr 2017 14:36:45 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 |
On 18/04/2017 12:39, Fam Zheng wrote:
> + QLIST_FOREACH_SAFE(child, &bs->children, next, tmp) {
> + BlockDriverState *bs = child->bs;
> + assert(bs->refcnt > 0);
> + bdrv_ref(bs);
> + waited |= bdrv_drain_recurse(bs);
> + bdrv_unref(bs);
> }
I think this accesses global state that is not protected by the
AioContext lock?
Paolo