[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/2] block: assert no image modification under B
|
From: |
Max Reitz |
|
Subject: |
Re: [Qemu-devel] [PATCH 2/2] block: assert no image modification under BDRV_O_INACTIVE |
|
Date: |
Thu, 13 Apr 2017 21:09:59 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.0 |
On 05.04.2017 17:18, Denis V. Lunev wrote:
> As long as BDRV_O_INACTIVE is set, the image file is only opened so we
> have a file descriptor for it. We're definitely not supposed to modify
> the image, it's still owned by the migration source.
>
> This commit is an addition to 09e0c771 but the assert() is added to
> bdrv_truncate().
>
> Signed-off-by: Denis V. Lunev <address@hidden>
> CC: Kevin Wolf <address@hidden>
> CC: Max Reitz <address@hidden>
> ---
> block.c | 2 ++
> 1 file changed, 2 insertions(+)
Thanks to the new op blockers I'm not sure this is really necessary
anymore (that assertion should cover this, once it's reinstated, that
is...), but it won't hurt, I guess.
Max
signature.asc
Description: OpenPGP digital signature