[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] raspi: Add Raspberry Pi 1 support
|
From: |
Eric Blake |
|
Subject: |
Re: [Qemu-devel] [PATCH] raspi: Add Raspberry Pi 1 support |
|
Date: |
Wed, 12 Apr 2017 19:04:33 -0500 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 |
On 04/12/2017 06:57 PM, address@hidden wrote:
> Hi,
>
> This series seems to have some coding style problems. See output below for
> more information:
> === OUTPUT BEGIN ===
> Checking PATCH 1/1: raspi: Add Raspberry Pi 1 support...
> ERROR: line over 90 characters
> #189: FILE: hw/arm/raspi.c:34:
> + *
> https://github.com/AndrewFromMelbourne/raspberry_pi_revision/blob/2764c19983fb7b1ef8cb21031e94c293703afa2e/README.md
You can shorten this:
https://github.com/AndrewFromMelbourne/raspberry_pi_revision/blob/2764c199/README.md
to fit under 90, while still resolving to the same place (collisions
with just an 8-char prefix are rare enough to generally not be an issue
to git)
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature