[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH for-2.9?] qga-win: Enable 'can-offline' field in
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH for-2.9?] qga-win: Enable 'can-offline' field in 'guest-get-vcpus' reply |
Date: |
Tue, 11 Apr 2017 08:25:06 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 |
On 04/11/2017 07:52 AM, Sameeh Jubran wrote:
> The QGA schema states:
>
> @can-offline: Whether offlining the VCPU is possible. This member
> is always filled in by the guest agent when the structure
> is returned, and always ignored on input (hence it can be
> omitted then).
>
> Currently 'can-offline' is missing entirely from the reply. This causes
> errors in libvirt which is expecting the reply to be compliant with the
> schema docs.
>
> BZ#1438735: https://bugzilla.redhat.com/show_bug.cgi?id=1438735
>
> Signed-off-by: Sameeh Jubran <address@hidden>
> ---
> qga/commands-win32.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Appropriate as a bug fix in 2.9 if there is still time for the
maintainer to submit a pull request, although we are late enough that if
it slips into 2.10 it is not a big deal.
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature