[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 11/54] ram: Change num_dirty_pages_period type t
From: |
Dr. David Alan Gilbert |
Subject: |
Re: [Qemu-devel] [PATCH 11/54] ram: Change num_dirty_pages_period type to uint64_t |
Date: |
Fri, 7 Apr 2017 10:44:55 +0100 |
User-agent: |
Mutt/1.8.0 (2017-02-23) |
* Juan Quintela (address@hidden) wrote:
> Signed-off-by: Juan Quintela <address@hidden>
> ---
> include/exec/ram_addr.h | 2 +-
> migration/ram.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/include/exec/ram_addr.h b/include/exec/ram_addr.h
> index b05dc84..9aadc5c 100644
> --- a/include/exec/ram_addr.h
> +++ b/include/exec/ram_addr.h
> @@ -356,7 +356,7 @@ static inline
> uint64_t cpu_physical_memory_sync_dirty_bitmap(unsigned long *dest,
> ram_addr_t start,
> ram_addr_t length,
> - int64_t *real_dirty_pages)
> + uint64_t *real_dirty_pages)
right that makes sense because num_dirty_pages_period gets passed to it.
> {
> ram_addr_t addr;
> unsigned long page = BIT_WORD(start >> TARGET_PAGE_BITS);
> diff --git a/migration/ram.c b/migration/ram.c
> index d6cf032..9a82355 100644
> --- a/migration/ram.c
> +++ b/migration/ram.c
> @@ -160,7 +160,7 @@ struct RAMState {
> /* bytes transferred at start_time */
> uint64_t bytes_xfer_prev;
> /* number of dirty pages since start_time */
> - int64_t num_dirty_pages_period;
> + uint64_t num_dirty_pages_period;
and trace_migration_bitmap_sync_end is already using PRIu64 so
that sohuld be OK.
Reviewed-by: Dr. David Alan Gilbert <address@hidden>
> };
> typedef struct RAMState RAMState;
>
> --
> 2.9.3
>
--
Dr. David Alan Gilbert / address@hidden / Manchester, UK
- [Qemu-devel] [PATCH 04/54] ram: Create RAMState, (continued)
- [Qemu-devel] [PATCH 04/54] ram: Create RAMState, Juan Quintela, 2017/04/06
- [Qemu-devel] [PATCH 01/54] ram: Update all functions comments, Juan Quintela, 2017/04/06
- [Qemu-devel] [PATCH 05/54] ram: Add dirty_rate_high_cnt to RAMState, Juan Quintela, 2017/04/06
- [Qemu-devel] [PATCH 07/54] ram: Move start time into RAMState, Juan Quintela, 2017/04/06
- [Qemu-devel] [PATCH 08/54] ram: Move bytes_xfer_prev into RAMState, Juan Quintela, 2017/04/06
- [Qemu-devel] [PATCH 09/54] ram: Change byte_xfer_now type to uint64_t, Juan Quintela, 2017/04/06
- [Qemu-devel] [PATCH 11/54] ram: Change num_dirty_pages_period type to uint64_t, Juan Quintela, 2017/04/06
- [Qemu-devel] [PATCH 10/54] ram: Move num_dirty_pages_period into RAMState, Juan Quintela, 2017/04/06
- [Qemu-devel] [PATCH 13/54] ram: Move iterations_prev into RAMState, Juan Quintela, 2017/04/06
- [Qemu-devel] [PATCH 12/54] ram: Move xbzrle_cache_miss_prev into RAMState, Juan Quintela, 2017/04/06
- [Qemu-devel] [PATCH 14/54] ram: Move dup_pages into RAMState, Juan Quintela, 2017/04/06
- [Qemu-devel] [PATCH 15/54] ram: Remove unused dup_mig_bytes_transferred(), Juan Quintela, 2017/04/06
- [Qemu-devel] [PATCH 16/54] ram: Remove unused pages_skipped variable, Juan Quintela, 2017/04/06
- [Qemu-devel] [PATCH 19/54] ram: Move iterations into RAMState, Juan Quintela, 2017/04/06
- [Qemu-devel] [PATCH 20/54] ram: Move xbzrle_bytes into RAMState, Juan Quintela, 2017/04/06
- [Qemu-devel] [PATCH 18/54] ram: Remove norm_mig_bytes_transferred, Juan Quintela, 2017/04/06