[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 03/13] s390x: Drop useless casts
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v3 03/13] s390x: Drop useless casts |
Date: |
Thu, 6 Apr 2017 08:31:29 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 |
On 04/06/2017 02:36 AM, Cornelia Huck wrote:
> On Wed, 5 Apr 2017 14:47:31 -0500
> Eric Blake <address@hidden> wrote:
>
>> An upcoming Coccinelle cleanup script wanted to reformat the casts
>> present in this file - but on closer look, we don't need the casts
>> at all because C automatically converts void* to any other pointer.
>>
>> Signed-off-by: Eric Blake <address@hidden>
>> ---
>> target/s390x/cpu_models.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>
> Do you prefer to keep this in this series, or should we just go ahead
> and apply this via s390x?
I'm okay either way. It's trivial enough, and although I found it during
qapi cleanups, it is clearly independent enough that I don't mind
rebasing if you pick it up and apply first through a non-qapi tree.
>
> In any case,
>
> Acked-by: Cornelia Huck <address@hidden>
>
>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-devel] [PATCH v3 01/13] pci: Use struct instead of QDict to pass back parameters, (continued)
- [Qemu-devel] [PATCH v3 02/13] pci: Reduce scope of error injection, Eric Blake, 2017/04/05
- [Qemu-devel] [PATCH v3 04/13] coccinelle: Add script to remove useless QObject casts, Eric Blake, 2017/04/05
- [Qemu-devel] [PATCH v3 03/13] s390x: Drop useless casts, Eric Blake, 2017/04/05
- [Qemu-devel] [PATCH v3 06/13] qobject: Add helper macros for common scalar insertions, Eric Blake, 2017/04/05
- [Qemu-devel] [PATCH v3 05/13] qobject: Drop useless QObject casts, Eric Blake, 2017/04/05
- [Qemu-devel] [PATCH v3 08/13] tests: Use simpler QDict/QList scalar insertion macros, Eric Blake, 2017/04/05
- [Qemu-devel] [PATCH v3 11/13] QemuOpts: Simplify qemu_opts_to_qdict(), Eric Blake, 2017/04/05
- [Qemu-devel] [PATCH v3 10/13] block: Simplify bdrv_append_temp_snapshot() logic, Eric Blake, 2017/04/05