[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 10/10] [testing] console: remove do_safe_dpy_refresh
From: |
Gerd Hoffmann |
Subject: |
[Qemu-devel] [PATCH 10/10] [testing] console: remove do_safe_dpy_refresh |
Date: |
Tue, 4 Apr 2017 12:23:15 +0200 |
Drop the temporary workaround for the broken display updates.
TODO: before actually merging this we have to fix all display
adapters ...
Converted so far: vga, cg3, tcx.
Signed-off-by: Gerd Hoffmann <address@hidden>
---
ui/console.c | 25 +------------------------
1 file changed, 1 insertion(+), 24 deletions(-)
diff --git a/ui/console.c b/ui/console.c
index 419b098..4c70d8b 100644
--- a/ui/console.c
+++ b/ui/console.c
@@ -1575,36 +1575,13 @@ bool dpy_gfx_check_format(QemuConsole *con,
return true;
}
-/*
- * Safe DPY refresh for TCG guests. We use the exclusive mechanism to
- * ensure the TCG vCPUs are quiescent so we can avoid races between
- * dirty page tracking for direct frame-buffer access by the guest.
- *
- * This is a temporary stopgap until we've fixed the dirty tracking
- * races in display adapters.
- */
-static void do_safe_dpy_refresh(DisplayChangeListener *dcl)
-{
- qemu_mutex_unlock_iothread();
- start_exclusive();
- qemu_mutex_lock_iothread();
- dcl->ops->dpy_refresh(dcl);
- qemu_mutex_unlock_iothread();
- end_exclusive();
- qemu_mutex_lock_iothread();
-}
-
static void dpy_refresh(DisplayState *s)
{
DisplayChangeListener *dcl;
QLIST_FOREACH(dcl, &s->listeners, next) {
if (dcl->ops->dpy_refresh) {
- if (tcg_enabled()) {
- do_safe_dpy_refresh(dcl);
- } else {
- dcl->ops->dpy_refresh(dcl);
- }
+ dcl->ops->dpy_refresh(dcl);
}
}
}
--
2.9.3
- [Qemu-devel] [PATCH 00/10] make display updates thread safe., Gerd Hoffmann, 2017/04/04
- [Qemu-devel] [PATCH 09/10] tcx: make display updates thread safe, Gerd Hoffmann, 2017/04/04
- [Qemu-devel] [PATCH 02/10] memory: add support getting and using a dirty bitmap copy., Gerd Hoffmann, 2017/04/04
- [Qemu-devel] [PATCH 06/10] cg3: fix up size parameter for memory_region_get_dirty(), Gerd Hoffmann, 2017/04/04
- [Qemu-devel] [PATCH 10/10] [testing] console: remove do_safe_dpy_refresh,
Gerd Hoffmann <=
- [Qemu-devel] [PATCH 03/10] vga: add vga_scanline_invalidated helper, Gerd Hoffmann, 2017/04/04
- [Qemu-devel] [PATCH 08/10] tcx: introduce tcx_check_dirty() function, Gerd Hoffmann, 2017/04/04
- [Qemu-devel] [PATCH 05/10] cg3: remove TARGET_PAGE_SIZE rounding on dirty page detection, Gerd Hoffmann, 2017/04/04
- [Qemu-devel] [PATCH 01/10] bitmap: add bitmap_copy_and_clear_atomic, Gerd Hoffmann, 2017/04/04
- [Qemu-devel] [PATCH 07/10] cg3: make display updates thread safe, Gerd Hoffmann, 2017/04/04
- [Qemu-devel] [PATCH 04/10] vga: make display updates thread safe., Gerd Hoffmann, 2017/04/04
- Re: [Qemu-devel] [PATCH 00/10] make display updates thread safe., Mark Cave-Ayland, 2017/04/04