|
| From: | Alexander Graf |
| Subject: | Re: [Qemu-devel] [PATCH v1 2/3] applesmc: consolidate port i/o into single contiguous region |
| Date: | Mon, 3 Apr 2017 11:32:25 +0200 |
| User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 |
On 03/31/2017 06:48 PM, Gabriel L. Somlo wrote:
Newer AppleSMC revisions support an error status (read) port in addition to the data and command ports currently supported. Register the full 32-bit region at once, and handle individual ports at various offsets within the region from the top-level applesmc_io_[write|read]() methods (ctual support for reading the error status port to be added by a subsequent patch). Originally proposed by Eric Shelton <address@hidden> Signed-off-by: Gabriel Somlo <address@hidden>
I would prefer if we could leave the multiplexing to the layer that knows how to do that the best: Memory Regions.
Why don't you just define a big region that ecompasses all of the IO space (with fallback I/O handlers for warnings) and then just sprinkle the ones we handle on top with higher prio?
Alex
| [Prev in Thread] | Current Thread | [Next in Thread] |