[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [RFC 16/19] generic-sdhci: Remove user_creatable flag
From: |
Eduardo Habkost |
Subject: |
[Qemu-devel] [RFC 16/19] generic-sdhci: Remove user_creatable flag |
Date: |
Fri, 31 Mar 2017 21:46:21 -0300 |
generic-sdhci needs to be wired by other devices' code, so it
can't be used with -device. Remove the user_creatable flag from
the device class.
Cc: Peter Maydell <address@hidden>
Cc: "Edgar E. Iglesias" <address@hidden>
Cc: David Gibson <address@hidden>
Cc: Alexander Graf <address@hidden>
Cc: "Michael S. Tsirkin" <address@hidden>
Cc: Marcel Apfelbaum <address@hidden>
Cc: Prasad J Pandit <address@hidden>
Cc: Alistair Francis <address@hidden>
Signed-off-by: Eduardo Habkost <address@hidden>
---
hw/sd/sdhci.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/hw/sd/sdhci.c b/hw/sd/sdhci.c
index 186555188b..6d6a791ee9 100644
--- a/hw/sd/sdhci.c
+++ b/hw/sd/sdhci.c
@@ -1360,11 +1360,6 @@ static void sdhci_sysbus_class_init(ObjectClass *klass,
void *data)
dc->props = sdhci_sysbus_properties;
dc->realize = sdhci_sysbus_realize;
dc->reset = sdhci_poweron_reset;
- /*
- * FIXME: Set only for compatibility on q35 machine-type.
- * Probably never meant to be user-creatable
- */
- dc->user_creatable = true;
}
static const TypeInfo sdhci_sysbus_info = {
--
2.11.0.259.g40922b1
- [Qemu-devel] [RFC 03/19] sysbus: Set user_creatable=false by default on TYPE_SYS_BUS_DEVICE, (continued)
- [Qemu-devel] [RFC 03/19] sysbus: Set user_creatable=false by default on TYPE_SYS_BUS_DEVICE, Eduardo Habkost, 2017/03/31
- [Qemu-devel] [RFC 07/19] kvmclock: Remove user_creatable flag, Eduardo Habkost, 2017/03/31
- [Qemu-devel] [RFC 08/19] ioapic: Remove user_creatable flag, Eduardo Habkost, 2017/03/31
- [Qemu-devel] [RFC 09/19] kvmvapic: Remove user_creatable flag, Eduardo Habkost, 2017/03/31
- [Qemu-devel] [RFC 10/19] sysbus-ahci: Remove user_creatable flag, Eduardo Habkost, 2017/03/31
- [Qemu-devel] [RFC 12/19] isabus-bridge: Remove user_creatable flag, Eduardo Habkost, 2017/03/31
- [Qemu-devel] [RFC 13/19] unimplemented-device: Remove user_creatable flag, Eduardo Habkost, 2017/03/31
- [Qemu-devel] [RFC 11/19] allwinner-ahci: Remove user_creatable flag, Eduardo Habkost, 2017/03/31
- [Qemu-devel] [RFC 14/19] fw_cfg: Remove user_creatable flag, Eduardo Habkost, 2017/03/31
- [Qemu-devel] [RFC 15/19] esp: Remove user_creatable flag, Eduardo Habkost, 2017/03/31
- [Qemu-devel] [RFC 16/19] generic-sdhci: Remove user_creatable flag,
Eduardo Habkost <=
- [Qemu-devel] [RFC 17/19] hpet: Remove user_creatable flag, Eduardo Habkost, 2017/03/31
- [Qemu-devel] [RFC 18/19] sysbus-ohci: Remove user_creatable flag, Eduardo Habkost, 2017/03/31
- [Qemu-devel] [RFC 19/19] virtio-mmio: Remove user_creatable flag, Eduardo Habkost, 2017/03/31