[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [RFC 06/19] iommu: Remove FIXME comment about user_creatabl
From: |
Eduardo Habkost |
Subject: |
[Qemu-devel] [RFC 06/19] iommu: Remove FIXME comment about user_creatable=true |
Date: |
Fri, 31 Mar 2017 21:46:11 -0300 |
amd-iommu and intel-iommu are really meant to be used with
-device, so they need user_creatable=true. Remove the FIXME
comment.
Cc: Marcel Apfelbaum <address@hidden>
Cc: "Michael S. Tsirkin" <address@hidden>
Signed-off-by: Eduardo Habkost <address@hidden>
---
hw/i386/amd_iommu.c | 4 ----
hw/i386/intel_iommu.c | 4 ----
2 files changed, 8 deletions(-)
diff --git a/hw/i386/amd_iommu.c b/hw/i386/amd_iommu.c
index 1d139f3f6a..748c3648bb 100644
--- a/hw/i386/amd_iommu.c
+++ b/hw/i386/amd_iommu.c
@@ -1186,10 +1186,6 @@ static void amdvi_class_init(ObjectClass *klass, void*
data)
dc->vmsd = &vmstate_amdvi;
dc->hotpluggable = false;
dc_class->realize = amdvi_realize;
- /*
- * FIXME: Set only for compatibility on q35 machine-type.
- * Probably never meant to be user-creatable
- */
dc->user_creatable = true;
}
diff --git a/hw/i386/intel_iommu.c b/hw/i386/intel_iommu.c
index 5e5125f34b..1db33df5b7 100644
--- a/hw/i386/intel_iommu.c
+++ b/hw/i386/intel_iommu.c
@@ -2601,10 +2601,6 @@ static void vtd_class_init(ObjectClass *klass, void
*data)
dc->hotpluggable = false;
x86_class->realize = vtd_realize;
x86_class->int_remap = vtd_int_remap;
- /*
- * FIXME: Set only for compatibility on q35 machine-type.
- * Probably never meant to be user-creatable
- */
dc->user_creatable = true;
}
--
2.11.0.259.g40922b1
- [Qemu-devel] [RFC 00/19] sysbus: Don't allow -device/device_add by default, Eduardo Habkost, 2017/03/31
- [Qemu-devel] [RFC 02/19] s390: Add FIXME for unexplained user_creatable=false line, Eduardo Habkost, 2017/03/31
- [Qemu-devel] [RFC 01/19] qdev: Replace cannot_instantiate_with_device_add_yet with !user_creatable, Eduardo Habkost, 2017/03/31
- [Qemu-devel] [RFC 04/19] fdc: Remove user_creatable flag from sysbus-fdc & SUNW, fdtwo, Eduardo Habkost, 2017/03/31
- [Qemu-devel] [RFC 05/19] pflash_cfi01: Remove user_creatable flag, Eduardo Habkost, 2017/03/31
- [Qemu-devel] [RFC 06/19] iommu: Remove FIXME comment about user_creatable=true,
Eduardo Habkost <=
- [Qemu-devel] [RFC 03/19] sysbus: Set user_creatable=false by default on TYPE_SYS_BUS_DEVICE, Eduardo Habkost, 2017/03/31
- [Qemu-devel] [RFC 07/19] kvmclock: Remove user_creatable flag, Eduardo Habkost, 2017/03/31
- [Qemu-devel] [RFC 08/19] ioapic: Remove user_creatable flag, Eduardo Habkost, 2017/03/31
- [Qemu-devel] [RFC 09/19] kvmvapic: Remove user_creatable flag, Eduardo Habkost, 2017/03/31
- [Qemu-devel] [RFC 10/19] sysbus-ahci: Remove user_creatable flag, Eduardo Habkost, 2017/03/31
- [Qemu-devel] [RFC 12/19] isabus-bridge: Remove user_creatable flag, Eduardo Habkost, 2017/03/31
- [Qemu-devel] [RFC 13/19] unimplemented-device: Remove user_creatable flag, Eduardo Habkost, 2017/03/31
- [Qemu-devel] [RFC 11/19] allwinner-ahci: Remove user_creatable flag, Eduardo Habkost, 2017/03/31
- [Qemu-devel] [RFC 14/19] fw_cfg: Remove user_creatable flag, Eduardo Habkost, 2017/03/31
- [Qemu-devel] [RFC 15/19] esp: Remove user_creatable flag, Eduardo Habkost, 2017/03/31