|
From: | Marcel Apfelbaum |
Subject: | Re: [Qemu-devel] [PATCH v3] hw/unicore32: remove wrong assertion in puv machine init |
Date: | Thu, 30 Mar 2017 19:27:16 +0300 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.1 |
On 03/30/2017 07:17 PM, Suramya Shah wrote:
Signed-off-by: Suramya Shah <address@hidden>
Hi,
Running QEMU with qemu-system-unicore32 without the kernel parameter results in an assertion error. Assert should not be used to check user provided parameters. Report an error and exit instead
Put the "Signed-off-by" here, please
--- hw/unicore32/puv3.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/hw/unicore32/puv3.c b/hw/unicore32/puv3.c index 032078f..2c17cc9 100644 --- a/hw/unicore32/puv3.c +++ b/hw/unicore32/puv3.c @@ -93,8 +93,11 @@ static void puv3_load_kernel(const char *kernel_filename) if (kernel_filename == NULL && qtest_enabled()) { return; } - assert(kernel_filename != NULL); - + if (kernel_filename == NULL) { + error_report("No kernel found"); + exit(1); + } + /* only zImage format supported */ size = load_image_targphys(kernel_filename, KERNEL_LOAD_ADDR, KERNEL_MAX_SIZE);
Thanks, Marcel
[Prev in Thread] | Current Thread | [Next in Thread] |