Re: [Qemu-devel] [for-2.9 1/8] nbd sockets vnc: Mark problematic address family tests TODO

[Eric Blake]

On 03/29/2017 11:45 AM, Markus Armbruster wrote:
> Certain features make sense only with certain address families.  For
> instance, passing file descriptors requires AF_UNIX.  Testing
> SocketAddress's saddr->type == SOCKET_ADDRESS_KIND_UNIX is obvious,
> but problematic: it can't recognize AF_UNIX when type ==
> SOCKET_ADDRESS_KIND_FD.
> 
> Mark such tests of saddr->type TODO.  We may want to check the address
> family with getsockname() there.
> 
> Cc: Paolo Bonzini <address@hidden>
> Cc: Gerd Hoffmann <address@hidden>
> Cc: Daniel P. Berrange <address@hidden>
> Signed-off-by: Markus Armbruster <address@hidden>
> ---

Reviewed-by: Eric Blake <address@hidden>

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature