Re: [Qemu-devel] [PATCH v2 for-2.10 0/4] block: Add errp to b{lk, drv}_truncate()

[Max Reitz]

On 23.03.2017 19:05, Kevin Wolf wrote:
> Am 08.03.2017 um 20:14 hat Max Reitz geschrieben:
>> Having an Error parameter for these functions makes sense because we
>> sometimes want a bit more information than just "Something failed". Some
>> drivers already use error_report() and the like to emit this additional
>> information, so it's rather obvious that we do want a real error object
>> here.
> 
> I had only some minor comments about improving one error message or
> another, so whether you fix them or not:
> 
> Reviewed-by: Kevin Wolf <address@hidden>
> 
> (But if you don't fix them, you need to merge the patches yourself)

That sounds very fair, I like it. :-)

Don't worry, though, I will address them. Thanks for reviewing!

Max

signature.asc
Description: OpenPGP digital signature