Re: [Qemu-devel] [PATCH v3 for-2.9?] virtio: fix vring_align() on 64-bit windows

[Philippe Mathieu-Daudé]

Hi, I never received Andrew Baumann's mail via the ML...

On 03/28/2017 03:38 PM, Stefan Weil wrote:
> Am 25.03.2017 um 00:19 schrieb QEMU_ALIGN_UP:
> > long is 32-bits on 64-bit windows, which caused the top half of the
> > address to be truncated; this patch changes it to use the
> > QEMU_ALIGN_UP macro which does not suffer the same problem
> >
> > Signed-off-by: Andrew Baumann <address@hidden>
> > Reviewed-by: Eric Blake <address@hidden>

Reviewed-by: Philippe Mathieu-Daudé <address@hidden>

> > ---
> >  include/hw/virtio/virtio.h | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/include/hw/virtio/virtio.h b/include/hw/virtio/virtio.h
> > index 15efcf2..7b6edba 100644
> > --- a/include/hw/virtio/virtio.h
> > +++ b/include/hw/virtio/virtio.h
> > @@ -34,7 +34,7 @@ struct VirtQueue;
> >  static inline hwaddr vring_align(hwaddr addr,
> >                                               unsigned long align)
> >  {
> > -    return (addr + align - 1) & ~(align - 1);
> > +    return QEMU_ALIGN_UP(addr, align);
> >  }
> >
> >  typedef struct VirtQueue VirtQueue;
>
> Eric added "for-2.9" to the subject line of v2, but now it was
> missing again for v3.
>
> Is this needed for 2.9? I wonder why I never before noticed
> a problem or got a bug report for this issue.
>
> Regards
> Stefan