Re: [Qemu-devel] [RFC QEMU PATCH v2 00/10] Implement vNVDIMM for Xen HVM guest

[no-reply]

Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [Qemu-devel] [RFC QEMU PATCH v2 00/10] Implement vNVDIMM for Xen HVM 
guest
Message-id: address@hidden
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

# Useful git options
git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
4f4220c qapi: extend 'query-memory-devices' to list devices of specified type
b94652a xen-hvm: create hotplug memory region on Xen
a991ab5 hostmem: add a host memory backend for Xen
ffde33c xen-hvm: initiate building DM ACPI on i386 machine
cc1727b nvdimm acpi: build and copy NVDIMM namespace devices to guest on Xen
907e1e6 nvdimm acpi: copy NFIT to Xen guest
6643ba5 nvdimm acpi: do not use fw_cfg on Xen
d1d7314 xen-hvm: support copying ACPI to guest memory
b93f5aa xen-hvm: initialize DM ACPI
0e9a41d nvdimm xen: disable label support on Xen

=== OUTPUT BEGIN ===
Checking PATCH 1/10: nvdimm xen: disable label support on Xen...
ERROR: braces {} are necessary for all arms of this statement
#26: FILE: hw/mem/nvdimm.c:93:
+    if (nvdimm->label_size)
[...]

total: 1 errors, 0 warnings, 12 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 2/10: xen-hvm: initialize DM ACPI...
Checking PATCH 3/10: xen-hvm: support copying ACPI to guest memory...
Checking PATCH 4/10: nvdimm acpi: do not use fw_cfg on Xen...
ERROR: braces {} are necessary for all arms of this statement
#43: FILE: hw/acpi/nvdimm.c:892:
+    if (fw_cfg)
[...]

total: 1 errors, 0 warnings, 26 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 5/10: nvdimm acpi: copy NFIT to Xen guest...
Checking PATCH 6/10: nvdimm acpi: build and copy NVDIMM namespace devices to 
guest on Xen...
Checking PATCH 7/10: xen-hvm: initiate building DM ACPI on i386 machine...
Checking PATCH 8/10: hostmem: add a host memory backend for Xen...
Checking PATCH 9/10: xen-hvm: create hotplug memory region on Xen...
ERROR: braces {} are necessary for all arms of this statement
#29: FILE: hw/i386/pc.c:1365:
+    if (!pcmc->has_reserved_memory || machine->ram_size >= 
machine->maxram_size)
[...]

total: 1 errors, 0 warnings, 109 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 10/10: qapi: extend 'query-memory-devices' to list devices of 
specified type...
=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden