[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 9/9] scsi-generic: Fill in opt_xfer_len in INQUIRY re
From: |
Paolo Bonzini |
Subject: |
[Qemu-devel] [PULL 9/9] scsi-generic: Fill in opt_xfer_len in INQUIRY reply if it is zero |
Date: |
Mon, 27 Mar 2017 18:16:15 +0200 |
From: Fam Zheng <address@hidden>
When opt_xfer_len is zero, Linux ignores max_xfer_len erroneously.
While that obviously should be fixed, we do older guests a favor to
always filling in a value.
Signed-off-by: Fam Zheng <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>
---
hw/scsi/scsi-generic.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/hw/scsi/scsi-generic.c b/hw/scsi/scsi-generic.c
index 2933119..a55ff87 100644
--- a/hw/scsi/scsi-generic.c
+++ b/hw/scsi/scsi-generic.c
@@ -237,9 +237,8 @@ static void scsi_read_complete(void * opaque, int ret)
assert(max_transfer);
stl_be_p(&r->buf[8], max_transfer);
/* Also take care of the opt xfer len. */
- if (ldl_be_p(&r->buf[12]) > max_transfer) {
- stl_be_p(&r->buf[12], max_transfer);
- }
+ stl_be_p(&r->buf[12],
+ MIN_NON_ZERO(max_transfer, ldl_be_p(&r->buf[12])));
}
scsi_req_data(&r->req, len);
scsi_req_unref(&r->req);
--
2.9.3
- [Qemu-devel] [PULL 0/9] Misc fixes for QEMU 2.9.0-rc2, Paolo Bonzini, 2017/03/27
- [Qemu-devel] [PULL 2/9] virtio-scsi: Make virtio_scsi_acquire/release public, Paolo Bonzini, 2017/03/27
- [Qemu-devel] [PULL 3/9] virtio-scsi: Fix acquire/release in dataplane handlers, Paolo Bonzini, 2017/03/27
- [Qemu-devel] [PULL 4/9] tcg/i386: Check the size of instruction being translated, Paolo Bonzini, 2017/03/27
- [Qemu-devel] [PULL 1/9] clear pending status before calling memory commit, Paolo Bonzini, 2017/03/27
- [Qemu-devel] [PULL 5/9] mem-prealloc: fix sysconf(_SC_NPROCESSORS_ONLN) failure case., Paolo Bonzini, 2017/03/27
- [Qemu-devel] [PULL 6/9] win32: replace custom mutex and condition variable with native primitives, Paolo Bonzini, 2017/03/27
- [Qemu-devel] [PULL 7/9] nbd: drop unused NBDClientSession.is_unix field, Paolo Bonzini, 2017/03/27
- [Qemu-devel] [PULL 8/9] Revert "apic: save apic_delivered flag", Paolo Bonzini, 2017/03/27
- [Qemu-devel] [PULL 9/9] scsi-generic: Fill in opt_xfer_len in INQUIRY reply if it is zero,
Paolo Bonzini <=
- Re: [Qemu-devel] [PULL 0/9] Misc fixes for QEMU 2.9.0-rc2, Peter Maydell, 2017/03/28