[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH RFC v2 1/9] rbd: Reject -blockdev server.*.{nume
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH RFC v2 1/9] rbd: Reject -blockdev server.*.{numeric, to, ipv4, ipv6} |
Date: |
Fri, 24 Mar 2017 13:05:38 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 |
On 03/24/2017 12:44 PM, Markus Armbruster wrote:
> We use InetSocketAddress in the QAPI schema. However, the code
> doesn't use inet_connect_saddr(), but formats "host" and "port" into a
> configuration string for rados_conf_set(). Thus, members "numeric",
> "to", "ipv4" and "ipv6" are silently ignored. Not nice. Example:
>
> -blockdev
> rbd,node-name=nn,pool=p,image=i,server.0.host=h0,server.0.port=12345,server.0.ipv4=off
>
> Factor a suitable InetSocketAddressBase out of InetSocketAddress, and
> use that. "numeric", "to", "ipv4" and "ipv6" are now rejected.
Are now rejected when using -blockdev-add or QMP, but are still
(silently) ignored when using -drive [fixed later in series].
>
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
> qapi-schema.json | 21 ++++++++++++++-------
> qapi/block-core.json | 2 +-
> 2 files changed, 15 insertions(+), 8 deletions(-)
>
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH RFC v2 0/9] rbd: Clean up API and code, Markus Armbruster, 2017/03/24
- [Qemu-devel] [PATCH RFC v2 1/9] rbd: Reject -blockdev server.*.{numeric, to, ipv4, ipv6}, Markus Armbruster, 2017/03/24
- Re: [Qemu-devel] [PATCH RFC v2 1/9] rbd: Reject -blockdev server.*.{numeric, to, ipv4, ipv6},
Eric Blake <=
- [Qemu-devel] [PATCH RFC v2 2/9] rbd: Fix to cleanly reject -drive without pool or image, Markus Armbruster, 2017/03/24
- [Qemu-devel] [PATCH RFC v2 4/9] rbd: Clean up after the previous commit, Markus Armbruster, 2017/03/24
- [Qemu-devel] [PATCH RFC v2 9/9] rbd: Reject invalid authentication methods, Markus Armbruster, 2017/03/24
- [Qemu-devel] [PATCH RFC v2 7/9] rbd: Clean up qemu_rbd_create()'s detour through QemuOpts, Markus Armbruster, 2017/03/24
- [Qemu-devel] [PATCH RFC v2 8/9] rbd: Rewrite the code to extract list-valued options, Markus Armbruster, 2017/03/24
- [Qemu-devel] [PATCH RFC v2 3/9] rbd: Don't limit length of parameter values, Markus Armbruster, 2017/03/24