[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] .PO files modified under build
From: |
Dr. David Alan Gilbert |
Subject: |
Re: [Qemu-devel] .PO files modified under build |
Date: |
Fri, 24 Mar 2017 11:58:31 +0000 |
User-agent: |
Mutt/1.8.0 (2017-02-23) |
* James Hanley (address@hidden) wrote:
> I have a git clone of qemu, and I build out of qemu-build... essentially
> the layout looks like:
> ./
> ./qemu/ -> clone of qemu
> ./qemu-build/
> ./Makefile
>
> The contents of the top level Makefile contain the following rules:
> rwildcard=$(wildcard $1$2) $(foreach d,$(wildcard $1*),$(call
> rwildcard,$d/,$2))
> files := $(call rwildcard,qemu/,*.[ch])
>
> .PHONY: clean_orphan_artifacts
> clean_orphan_artifacts: $(note update)
> $(Q) \
> $(GIT_VERBOSE) ; \
> cd qemu && \
> git clean -f -d -X
> $(call trace,GIT CLEAN)
>
> qemu-build: qemu $(files) clean_orphan_artifacts
> $(Q) \
> mkdir -p $(@) && \
> cd $(@) && \
> ../qemu/configure \
> --prefix=$(current_path)/local \
> --target-list=arm-softmmu \
> --disable-werror && \
> $(MAKE) && \
> $(MAKE) install \
> $(call trace,BUILD)
>
> It seems that somehow the .po files are being modified under the qemu repo
> even though the entire build is out of ./qemu-build.
>
> The two questions are:
> Should the .po files be modified under the qemu path when building out
> of another (ie qemu-build)?
> Should the .po files continue to be versioned or placed in .gitignore if
> they are (apparently) generated?
It's a known problem we've had for ages, and IMHO really needs fixing.
Dave
--
Dr. David Alan Gilbert / address@hidden / Manchester, UK