Re: [Qemu-devel] [PATCH for-2.9] disas/microblaze: Remove unused REG_PC define

[Peter Maydell]

On 23 March 2017 at 19:41, Edgar E. Iglesias <address@hidden> wrote:
> On Thu, Mar 23, 2017 at 12:42:41PM +0000, Peter Maydell wrote:
>> The REG_PC define in disas/microblaze.c clashes with a define in
>> the Linux SPARC system headers:
>>
>> /home/pm215/qemu/disas/microblaze.c:162:0: error: "REG_PC" redefined 
>> [-Werror]
>>  #define REG_PC  32 /* PC */
>>
>> In file included from /usr/include/signal.h:326:0,
>>                  from /home/pm215/qemu/include/qemu/osdep.h:86,
>>                  from /home/pm215/qemu/disas/microblaze.c:36:
>> /usr/include/sparc64-linux-gnu/sys/ucontext.h:96:0: note: this is the 
>> location of the previous definition
>>  #define REG_PC  (1)
>>
>> Since the code doesn't actually use the REG_PC define
>> anywhere, the simplest fix is just to remove it.
>
>
> Reviewed-by: Edgar E. Iglesias <address@hidden>

Thanks; applied to master.

-- PMM