[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] hw: dead code removal
|
From: |
Markus Armbruster |
|
Subject: |
Re: [Qemu-devel] [PATCH] hw: dead code removal |
|
Date: |
Tue, 21 Mar 2017 12:56:56 +0100 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) |
Paolo Bonzini <address@hidden> writes:
> On 21/03/2017 10:37, Markus Armbruster wrote:
>> Four related changes, really:
>>
>> 1. HDACodecDeviceClass method exit()
>> 2. VirtIOCCWDeviceClass method exit()
>> 3. DeviceClass method exit()
>> 4. SCLPEventClass method exit()
>>
>> Regarding 3: method exit() needs to go. Your patch shows there are only
>> a few remaining users. Please convert them to unrealize().
>
> But that should be a separate patch anyway, so this patch should be good
> as is, shouldn't it?
Separate, yes, but I'd do it first. Of course that's a matter of taste.