|
From: | Zhang Chen |
Subject: | Re: [Qemu-devel] Subject: [PATCH]COLO: Fix spell error in Colo doc |
Date: | Tue, 21 Mar 2017 11:04:54 +0800 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 |
Hi~~ Wang. This is a doc typo, but I found we forgot to update command in this doc, Recently COLO use this command:{'execute': 'nbd-server-add', 'arguments': {'device': 'colo-disk0', 'writable': true } }
You can see it in http://wiki.qemu-project.org/Features/COLO.So I think this patch is not necessary, I will update new command in docs/COLO-FT.txt later.
Please next time use scripts/get_maintainer.pl to cc related maintainers. Thanks Zhang Chen On 03/21/2017 11:01 AM, Eric Blake wrote:
On 03/20/2017 09:49 PM, wangguang wrote:This is an error in COLO-FT.txt. secondeary-disk0 should be secondary-disk0. Signed-off-by: Guang Wang <address@hidden>This is now version 6 of a patch, but failed to include that information in the subject line. 'git send-email -v6' would do that automatically for you.---I already gave a positive review on v4, and repeated that on v5. If you are going to continue sending revisions to the list (rather than relying on a maintainer to fix things up), then please remember to add Reviewed-by tags from earlier revisions if you didn't change any code, or else to include a changelog highlighting your code changes. Other advice on sending a good patch can be seen at: http://wiki.qemu-project.org/Contribute/SubmitAPatch
-- Thanks Zhang Chen
[Prev in Thread] | Current Thread | [Next in Thread] |