qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH for-2.9 30/47] tests/qapi-schema: Improve doc /


From: Eric Blake
Subject: Re: [Qemu-devel] [PATCH for-2.9 30/47] tests/qapi-schema: Improve doc / expression mismatch coverage
Date: Tue, 14 Mar 2017 15:02:07 -0500
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0

On 03/13/2017 01:18 AM, Markus Armbruster wrote:
> New test doc-bad-expr.json shows we fail to reject a misplaced
> expression comment.
> 
> New test doc-no-symbol.json shows a bad error message.
> 
> Signed-off-by: Markus Armbruster <address@hidden>
> ---

> +++ b/tests/qapi-schema/doc-no-symbol.err
> @@ -0,0 +1 @@
> +tests/qapi-schema/doc-no-symbol.json:4: Definition of 'foo' follows 
> documentation for 'None'

Yep, that's python implementation leaking through.

> +++ b/tests/qapi-schema/doc-no-symbol.json
> @@ -0,0 +1,7 @@
> +# Documentation for expression lacks symbol
> +# BUG: Error message claims it has symbol 'None'

Reviewed-by: Eric Blake <address@hidden>

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]