[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v6 06/10] blkdebug: Refactor error injection
From: |
Max Reitz |
Subject: |
Re: [Qemu-devel] [PATCH v6 06/10] blkdebug: Refactor error injection |
Date: |
Mon, 13 Mar 2017 23:16:55 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 |
On 08.03.2017 03:54, Eric Blake wrote:
> Rather than repeat the logic at each caller of checking if a Rule
> exists that warrants an error injection, fold that logic into
> inject_error(); and rename it to rule_check() for legibility.
> This will help the next patch, which adds two more callers that
> need to check rules for the potential of injecting errors.
>
> Signed-off-by: Eric Blake <address@hidden>
>
> ---
> v6: new patch
> ---
> block/blkdebug.c | 74
> +++++++++++++++++++++++++-------------------------------
> 1 file changed, 33 insertions(+), 41 deletions(-)
>
> diff --git a/block/blkdebug.c b/block/blkdebug.c
> index 7c804b2..f721bcb 100644
> --- a/block/blkdebug.c
> +++ b/block/blkdebug.c
Reviewed-by: Max Reitz <address@hidden>
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH v6 00/10] add blkdebug tests, Eric Blake, 2017/03/07
- [Qemu-devel] [PATCH v6 03/10] qcow2: Assert that cluster operations are aligned, Eric Blake, 2017/03/07
- [Qemu-devel] [PATCH v6 02/10] iotests: Improve image-clear tests on non-aligned image, Eric Blake, 2017/03/07
- [Qemu-devel] [PATCH v6 04/10] qcow2: Discard/zero clusters by byte count, Eric Blake, 2017/03/07
- [Qemu-devel] [PATCH v6 06/10] blkdebug: Refactor error injection, Eric Blake, 2017/03/07
- Re: [Qemu-devel] [PATCH v6 06/10] blkdebug: Refactor error injection,
Max Reitz <=
- [Qemu-devel] [PATCH v6 01/10] iotests: fix 097 when run with qcow, Eric Blake, 2017/03/07
- [Qemu-devel] [PATCH v6 08/10] blkdebug: Simplify override logic, Eric Blake, 2017/03/07
- [Qemu-devel] [PATCH v6 07/10] blkdebug: Add pass-through write_zero and discard support, Eric Blake, 2017/03/07
- [Qemu-devel] [PATCH v6 05/10] blkdebug: Sanity check block layer guarantees, Eric Blake, 2017/03/07
- [Qemu-devel] [PATCH v6 09/10] blkdebug: Add ability to override unmap geometries, Eric Blake, 2017/03/07
- [Qemu-devel] [PATCH v6 10/10] tests: Add coverage for recent block geometry fixes, Eric Blake, 2017/03/07
- Re: [Qemu-devel] [PATCH v6 00/10] add blkdebug tests, Kevin Wolf, 2017/03/08