[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v2 12/30] trace: Fix parameter types in hw/block
From: |
Eric Blake |
Subject: |
[Qemu-devel] [PATCH v2 12/30] trace: Fix parameter types in hw/block |
Date: |
Mon, 13 Mar 2017 14:55:29 -0500 |
An upcoming patch will let the compiler warn us when we are silently
losing precision in traces; in this patch, switching from
'/ BDRV_SECTOR_SIZE' (which changes types to unsigned long long) to
'>> BDRV_SECTOR_BITS' (which preserves the type at size_t) is sufficient
to match the existing trace definition.
Signed-off-by: Eric Blake <address@hidden>
---
hw/block/virtio-blk.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/block/virtio-blk.c b/hw/block/virtio-blk.c
index 98c16a7..b609202 100644
--- a/hw/block/virtio-blk.c
+++ b/hw/block/virtio-blk.c
@@ -529,11 +529,11 @@ static int virtio_blk_handle_request(VirtIOBlockReq *req,
MultiReqBuffer *mrb)
if (is_write) {
qemu_iovec_init_external(&req->qiov, iov, out_num);
trace_virtio_blk_handle_write(req, req->sector_num,
- req->qiov.size / BDRV_SECTOR_SIZE);
+ req->qiov.size >> BDRV_SECTOR_BITS);
} else {
qemu_iovec_init_external(&req->qiov, in_iov, in_num);
trace_virtio_blk_handle_read(req, req->sector_num,
- req->qiov.size / BDRV_SECTOR_SIZE);
+ req->qiov.size >> BDRV_SECTOR_BITS);
}
if (!virtio_blk_sect_range_ok(req->dev, req->sector_num,
--
2.9.3
- Re: [Qemu-devel] [PATCH v2 06/30] trace: Fix parameter types in migration, (continued)
- [Qemu-devel] [PATCH v2 04/30] trace: Fix parameter types in block, Eric Blake, 2017/03/13
- [Qemu-devel] [PATCH v2 07/30] trace: Fix parameter types in ui, Eric Blake, 2017/03/13
- [Qemu-devel] [PATCH v2 08/30] trace: Fix parameter types in top level, Eric Blake, 2017/03/13
- [Qemu-devel] [PATCH v2 10/30] trace: Fix parameter types in hw/acpi, Eric Blake, 2017/03/13
- [Qemu-devel] [PATCH v2 13/30] trace: Fix parameter types in hw/char, Eric Blake, 2017/03/13
- [Qemu-devel] [PATCH v2 16/30] trace: Fix parameter types in hw/i386, Eric Blake, 2017/03/13
- [Qemu-devel] [PATCH v2 11/30] trace: Fix parameter types in hw/audio, Eric Blake, 2017/03/13
- [Qemu-devel] [PATCH v2 09/30] trace: Fix parameter types in linux-user, Eric Blake, 2017/03/13
- [Qemu-devel] [PATCH v2 12/30] trace: Fix parameter types in hw/block,
Eric Blake <=
- [Qemu-devel] [PATCH v2 15/30] trace: Fix parameter types in hw/dma, Eric Blake, 2017/03/13
- [Qemu-devel] [PATCH v2 17/30] trace: Fix parameter types in hw/input, Eric Blake, 2017/03/13
- [Qemu-devel] [PATCH v2 14/30] trace: Fix parameter types in hw/display, Eric Blake, 2017/03/13
- [Qemu-devel] [PATCH v2 18/30] trace: Fix parameter types in hw/intc, Eric Blake, 2017/03/13
- [Qemu-devel] [PATCH v2 20/30] trace: Fix parameter types in hw/misc, Eric Blake, 2017/03/13
- [Qemu-devel] [PATCH v2 21/30] trace: Fix parameter types in hw/net, Eric Blake, 2017/03/13
- [Qemu-devel] [PATCH v2 19/30] trace: Fix parameter types in hw/isa, Eric Blake, 2017/03/13
- [Qemu-devel] [PATCH v2 22/30] trace: Fix parameter types in hw/nvram, Eric Blake, 2017/03/13
- [Qemu-devel] [PATCH v2 24/30] trace: Fix parameter types in hw/sd, Eric Blake, 2017/03/13