[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v2 05/30] trace: Fix parameter types in io
From: |
Eric Blake |
Subject: |
[Qemu-devel] [PATCH v2 05/30] trace: Fix parameter types in io |
Date: |
Mon, 13 Mar 2017 14:55:22 -0500 |
An upcoming patch will let the compiler warn us when we are silently
losing precision in traces. In this case, the only platform where
pid_t in the caller does not match int in the trace definition is
64-bit mingw, where the system headers are still buggy in declaring
a 64-bit pid_t even though getpid() only returns 32 bits, so a cast
in the caller is the easiest workaround.
Signed-off-by: Eric Blake <address@hidden>
---
io/channel-command.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/io/channel-command.c b/io/channel-command.c
index 319c5ed..a90a078 100644
--- a/io/channel-command.c
+++ b/io/channel-command.c
@@ -39,7 +39,7 @@ qio_channel_command_new_pid(int writefd,
ioc->writefd = writefd;
ioc->pid = pid;
- trace_qio_channel_command_new_pid(ioc, writefd, readfd, pid);
+ trace_qio_channel_command_new_pid(ioc, writefd, readfd, (int) pid);
return ioc;
}
--
2.9.3
- [Qemu-devel] [PATCH for-2.9 v2 00/30] trace type mismatch cleanups, Eric Blake, 2017/03/13
- [Qemu-devel] [PATCH v2 01/30] trace: Fix backwards mirror_yield parameters, Eric Blake, 2017/03/13
- [Qemu-devel] [PATCH v2 02/30] trace: Fix incorrect megasas trace parameters, Eric Blake, 2017/03/13
- [Qemu-devel] [PATCH v2 03/30] trace: Avoid abuse of amdvi_mmio_read, Eric Blake, 2017/03/13
- [Qemu-devel] [PATCH v2 05/30] trace: Fix parameter types in io,
Eric Blake <=
- [Qemu-devel] [PATCH v2 06/30] trace: Fix parameter types in migration, Eric Blake, 2017/03/13
- Re: [Qemu-devel] [PATCH v2 06/30] trace: Fix parameter types in migration, Dr. David Alan Gilbert, 2017/03/13
- Re: [Qemu-devel] [PATCH v2 06/30] trace: Fix parameter types in migration, Eric Blake, 2017/03/13
- Re: [Qemu-devel] [PATCH v2 06/30] trace: Fix parameter types in migration, Dr. David Alan Gilbert, 2017/03/14
- Re: [Qemu-devel] [PATCH v2 06/30] trace: Fix parameter types in migration, Eric Blake, 2017/03/14
- Re: [Qemu-devel] [PATCH v2 06/30] trace: Fix parameter types in migration, Eric Blake, 2017/03/15
- Re: [Qemu-devel] [PATCH v2 06/30] trace: Fix parameter types in migration, Eric Blake, 2017/03/15
[Qemu-devel] [PATCH v2 04/30] trace: Fix parameter types in block, Eric Blake, 2017/03/13
[Qemu-devel] [PATCH v2 07/30] trace: Fix parameter types in ui, Eric Blake, 2017/03/13