Re: [Qemu-devel] [PATCH] osdep.h: pull in sys/sysmacros.h for major/minor/makedev

[Eric Blake]

On 02/15/2017 06:50 AM, Peter Maydell wrote:
> On 15 February 2017 at 03:02, Mike Frysinger <address@hidden> wrote:
>> On 10 Feb 2017 09:04, Peter Maydell wrote:
>>> I still think that it's a shame that glibc is breaking
>>> compatibility with where these macros have always been
>>> kept on every OS that's implemented them back to 2BSD...
>>
>> i don't think that characterization is accurate.  if it were,
>> autoconf wouldn't have a AC_HEADER_MAJOR helper.
> 
> Hmm, Googling suggests that Solaris (and perhaps
> other SysV Unixes) put them in mkdev.h.
> That doesn't explain why glibc is taking yet a third
> approach here rather than using either of the two
> previously used choices...

Whether or not you think glibc broke things, the fact remains that the
build is broken on current Fedora rawhide if we don't apply either this
or the other proposed patch (the one by Christopher Covington, which
I've now pinged)

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature