Re: [Qemu-devel] [PATCH v3 00/11] MTTCG fix-ups for 2.9

[Alex Bennée]

Pavel Dovgalyuk <address@hidden> writes:

> Hi,
>
>> From: address@hidden [mailto:address@hidden
>>
>> The next thing on my list it to look at the icount problems and review
>> Paolo's fixes for it. However those fixes should go in a separate
>> series and I assume via Paolo's tree.
>
> Do you mean those problems that completely broke icount?

Completely broke is a bit strong. Certainly I tested icount on my
patches but I missed the pathological failure mode that led to the
interaction between the BQL lock breaking patch and running a real
guest. It didn't break icount so much as slow down guests so much they
never got round to finishing their IRQ handling.

That certainly seems to be fixed by Paolo's patches.

> Are you going to fix it?

Yes. It is certainly not intentional to regress icount and it needs to
be fixed before we release 2.9.

If you can point me towards the record/replay test cases I'll make sure
I run them on the updated series.

>
>
>> Alex Bennée (9):
>>   vl/cpus: be smarter with icount and MTTCG
>>   target/i386/cpu.h: declare TCG_GUEST_DEFAULT_MO
>>   cpus.c: add additional error_report when !TARGET_SUPPORT_MTTCG
>>   sparc/sparc64: grab BQL before calling cpu_check_irqs
>>   s390x/misc_helper.c: wrap IO instructions in BQL
>>   target/xtensa: hold BQL for interrupt processing
>>   translate-all: exit cpu_restore_state early if translating
>>   target/arm/helper: make it clear the EC field is also in hex
>>   hw/intc/arm_gic: modernise the DPRINTF
>>
>> Paolo Bonzini (1):
>>   target-i386: defer VMEXIT to do_interrupt
>>
>> Yongbok Kim (1):
>>   target/mips: hold BQL for timer interrupts
>
>
> Pavel Dovgalyuk


--
Alex Bennée