qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2] memory_region: Fix name comments


From: Paolo Bonzini
Subject: Re: [Qemu-devel] [PATCH v2] memory_region: Fix name comments
Date: Thu, 9 Mar 2017 17:26:42 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0


On 09/03/2017 17:13, Dr. David Alan Gilbert wrote:
>>> + * @name: Region name, becomes part of RAMBlock name used in migration 
>>> stream
>>> + *        must be unique within any device
>>>   * @size: size of the region; any subregions beyond this size will be 
>>> clipped
>>>   */
>>>  void memory_region_init(MemoryRegion *mr,
>>>                          struct Object *owner,
>>>                          const char *name,
>>>                          uint64_t size);
>> This one should not be necessary I guess?
> Why? It's not static so something else could be calling it for
> any use.

But why would the name end up in a RAMBlock?

Paolo



reply via email to

[Prev in Thread] Current Thread [Next in Thread]