Re: [Qemu-devel] [PATCH RFC 1/1] block: Handle NULL options correctly in raw_open

[Kevin Wolf]

Am 08.03.2017 um 03:15 hat Dong Jia Shi geschrieben:
> A normal call for raw_open should always pass in a non-NULL @options,
> but for some certain cases (e.g. trying to applying snapshot on a RBD
> image), they call raw_open with a NULL @options right after the calling
> for raw_close.
> 
> Let's take the NULL @options as a sign of trying to do raw_open again,
> and just simply return a success code.
> 
> Signed-off-by: Dong Jia Shi <address@hidden>

I think we rather need to fix bdrv_snapshot_goto() so that it doesn't
pass NULL, but the actual options that were given for the node (i.e.
bs->options).

Kevin