Re: [Qemu-devel] [PATCH v10 0/8] the reset of msix_init series

[Michael S. Tsirkin]

On Mon, Mar 06, 2017 at 04:10:42PM +0800, Cao jin wrote:
> Michael,
> Is this series ok for 2.9?
> 
> -- 
> Sincerely,
> Cao jin

I'll consider it for 2.10.  Sorry it's taking a long time, the benefit
here is rather small so I don't see a reason to hurry.

> On 02/25/2017 04:26 PM, Cao jin wrote:
> > v10 changelog:
> > 1. drop the unliked patch, introduce a new patch 1 according to mst's 
> > comments.
> > 2. base on the new patch, remove the following statements
> > 
> >         /* Any error other than -ENOTSUP(board's MSI support is broken)
> >          * is a programming error */
> >         assert(!ret || ret == -ENOTSUP);
> > 
> >    for the affected device: megasas, hcd-xhci. This is trivial changes,
> >    so I left the R-bs where it was.
> > 
> > Test:
> > 1. Detailed test via command line as v9
> > 2. make check hangs at: GTESTER check-qtest-x86_64. After ctrl-C, it says:
> > 
> >     make: *** [check-qtest-x86_64] Interrupt
> >     qemu-system-x86_64: Failed to read msg header. Read -1 instead of 12. 
> > Original request 11.
> >     qemu-system-x86_64: vhost VQ 0 ring restore failed: -1: Input/output 
> > error (5)
> >     qemu-system-x86_64: Failed to set msg fds.
> >     qemu-system-x86_64: vhost VQ 0 ring restore failed: -1: Invalid 
> > argument (22)
> > 
> >     qemu-system-x86_64: Failed to set msg fds.
> >     qemu-system-x86_64: vhost VQ 1 ring restore failed: -1: Invalid 
> > argument (22)
> > 
> >    Is it a regresstion or I missed something?
> > 
> > CC: Jason Wang <address@hidden>
> > CC: Gerd Hoffmann <address@hidden>
> > CC: Dmitry Fleytman <address@hidden>
> > CC: Michael S. Tsirkin <address@hidden>
> > CC: Hannes Reinecke <address@hidden>
> > CC: Paolo Bonzini <address@hidden>
> > CC: Alex Williamson <address@hidden>
> > CC: Markus Armbruster <address@hidden>
> > CC: Marcel Apfelbaum <address@hidden>
> > 
> > Cao jin (8):
> >   msix: Rename and create a wrapper
> >   megasas: change behaviour of msix switch
> >   hcd-xhci: change behaviour of msix switch
> >   megasas: undo the overwrites of msi user configuration
> >   vmxnet3: fix reference leak issue
> >   vmxnet3: remove unnecessary internal msix flag
> >   msi_init: convert assert to return -errno
> >   megasas: remove unnecessary megasas_use_msix()
> > 
> >  hw/net/vmxnet3.c      | 40 +++++++++++++++-------------------------
> >  hw/pci/msi.c          |  9 ++++++---
> >  hw/pci/msix.c         | 30 +++++++++++++++++++++---------
> >  hw/scsi/megasas.c     | 48 +++++++++++++++++++++++++-----------------------
> >  hw/usb/hcd-xhci.c     | 29 +++++++++++++++++++++--------
> >  hw/vfio/pci.c         | 12 ++++++------
> >  include/hw/pci/msix.h |  5 +++++
> >  7 files changed, 99 insertions(+), 74 deletions(-)
> > 
> 
> 
>