[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 05/28] qapi: Support multiple command registr
|
From: |
Eric Blake |
|
Subject: |
Re: [Qemu-devel] [PATCH v4 05/28] qapi: Support multiple command registries per program |
|
Date: |
Fri, 3 Mar 2017 13:52:34 -0600 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 |
On 03/03/2017 01:37 PM, Markus Armbruster wrote:
> Eric Blake <address@hidden> writes:
>
>> On 03/03/2017 06:32 AM, Markus Armbruster wrote:
>>> The command registry encapsulates a single command list. Give the
>>> functions using it a parameter instead. Define suitable command lists
>>> in monitor, guest agent and test-qmp-commands.
>>>
>> ...or is this leftovers from your debugging?
>
> Corret. I'll drop it.
>
>> The rest of the patch looks fine; it is converting a global variable
>> into a per-instance variable.
>
> Squashing in the obvious garbage collection. May I add your R-by?
>
Yes, with that squashed in,
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-devel] [PATCH v4 07/28] qmp: Clean up how we enforce capability negotiation, (continued)
[Qemu-devel] [PATCH v4 16/28] qapi: Make string input and opts visitor require non-null input, Markus Armbruster, 2017/03/03
[Qemu-devel] [PATCH v4 05/28] qapi: Support multiple command registries per program, Markus Armbruster, 2017/03/03
Re: [Qemu-devel] [PATCH v4 00/28] qapi: QMP dispatch and input visitor work, no-reply, 2017/03/03