Re: [Qemu-devel] [PATCH] hppa: avoid anonymous unions in designated initializers.

[no-reply]

Hi,

This series seems to have some coding style problems. See output below for
more information:

Message-id: address@hidden
Type: series
Subject: [Qemu-devel] [PATCH] hppa: avoid anonymous unions in designated 
initializers.

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

# Useful git options
git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]         patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
0eaaa9f hppa: avoid anonymous unions in designated initializers.

=== OUTPUT BEGIN ===
Checking PATCH 1/1: hppa: avoid anonymous unions in designated initializers....
ERROR: Macros with complex values should be enclosed in parenthesis
#161: FILE: target/hppa/translate.c:3343:
+#define FOP_DED  trans_fop_ded, .f.ded

ERROR: Macros with complex values should be enclosed in parenthesis
#162: FILE: target/hppa/translate.c:3344:
+#define FOP_DEDD trans_fop_dedd, .f.dedd

ERROR: Macros with complex values should be enclosed in parenthesis
#168: FILE: target/hppa/translate.c:3346:
+#define FOP_WEW  trans_fop_wew_0c, .f.wew

ERROR: Macros with complex values should be enclosed in parenthesis
#169: FILE: target/hppa/translate.c:3347:
+#define FOP_DEW  trans_fop_dew_0c, .f.dew

ERROR: Macros with complex values should be enclosed in parenthesis
#170: FILE: target/hppa/translate.c:3348:
+#define FOP_WED  trans_fop_wed_0c, .f.wed

ERROR: Macros with complex values should be enclosed in parenthesis
#171: FILE: target/hppa/translate.c:3349:
+#define FOP_WEWW trans_fop_weww_0c, .f.weww

ERROR: Macros with complex values should be enclosed in parenthesis
#183: FILE: target/hppa/translate.c:3428:
+#define FOP_WEW  trans_fop_wew_0e, .f.wew

ERROR: Macros with complex values should be enclosed in parenthesis
#184: FILE: target/hppa/translate.c:3429:
+#define FOP_DEW  trans_fop_dew_0e, .f.dew

ERROR: Macros with complex values should be enclosed in parenthesis
#185: FILE: target/hppa/translate.c:3430:
+#define FOP_WED  trans_fop_wed_0e, .f.wed

ERROR: Macros with complex values should be enclosed in parenthesis
#186: FILE: target/hppa/translate.c:3431:
+#define FOP_WEWW trans_fop_weww_0e, .f.weww

total: 10 errors, 0 warnings, 157 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden