|
From: | Cédric Le Goater |
Subject: | Re: [Qemu-devel] [PATCH] ppc/spapr: QOM'ify sPAPRRTCState |
Date: | Fri, 3 Mar 2017 15:49:15 +0100 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 |
On 03/03/2017 03:13 PM, Thomas Huth wrote: > On 03.03.2017 14:37, Cédric Le Goater wrote: >> Also use an 'Object *' under the sPAPR machine to hold the RTC >> object. > > The change from TYPE_SYS_BUS_DEVICE to TYPE_DEVICE is certainly a good > idea! But what's the advantage of using Object* instead of DeviceState* > in sPAPRMachineState ? it makes spapr_rtc_create() a little simpler. We could go even further and use a sPAPRRTCState under sPAPRMachineState that we would initialize with object_initialize(). C.
[Prev in Thread] | Current Thread | [Next in Thread] |