[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v4 15/28] qapi: Drop string input visitor method opt
From: |
Markus Armbruster |
Subject: |
[Qemu-devel] [PATCH v4 15/28] qapi: Drop string input visitor method optional() |
Date: |
Fri, 3 Mar 2017 13:32:35 +0100 |
visit_optional() is to be called only between visit_start_struct() and
visit_end_struct(). Visitors that don't support struct visits,
i.e. don't implement start_struct(), end_struct(), have no use for it.
Clarify documentation.
The string input visitor doesn't support struct visits. Its
parse_optional() is therefore useless. Drop it.
Signed-off-by: Markus Armbruster <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
---
include/qapi/visitor-impl.h | 4 ++--
qapi/string-input-visitor.c | 13 -------------
2 files changed, 2 insertions(+), 15 deletions(-)
diff --git a/include/qapi/visitor-impl.h b/include/qapi/visitor-impl.h
index 8bd47ee..962ba1d 100644
--- a/include/qapi/visitor-impl.h
+++ b/include/qapi/visitor-impl.h
@@ -102,8 +102,8 @@ struct Visitor
/* Must be set to visit explicit null values. */
void (*type_null)(Visitor *v, const char *name, Error **errp);
- /* Must be set for input visitors, optional otherwise. The core
- * takes care of the return type in the public interface. */
+ /* Must be set for input visitors to visit structs, optional otherwise.
+ The core takes care of the return type in the public interface. */
void (*optional)(Visitor *v, const char *name, bool *present);
/* Must be set */
diff --git a/qapi/string-input-visitor.c b/qapi/string-input-visitor.c
index 8dfa561..1a855c5 100644
--- a/qapi/string-input-visitor.c
+++ b/qapi/string-input-visitor.c
@@ -314,18 +314,6 @@ static void parse_type_number(Visitor *v, const char
*name, double *obj,
*obj = val;
}
-static void parse_optional(Visitor *v, const char *name, bool *present)
-{
- StringInputVisitor *siv = to_siv(v);
-
- if (!siv->string) {
- *present = false;
- return;
- }
-
- *present = true;
-}
-
static void string_input_free(Visitor *v)
{
StringInputVisitor *siv = to_siv(v);
@@ -351,7 +339,6 @@ Visitor *string_input_visitor_new(const char *str)
v->visitor.start_list = start_list;
v->visitor.next_list = next_list;
v->visitor.end_list = end_list;
- v->visitor.optional = parse_optional;
v->visitor.free = string_input_free;
v->string = str;
--
2.7.4
- [Qemu-devel] [PATCH v4 08/28] qmp: Drop duplicated QMP command object checks, (continued)
- [Qemu-devel] [PATCH v4 08/28] qmp: Drop duplicated QMP command object checks, Markus Armbruster, 2017/03/03
- [Qemu-devel] [PATCH v4 09/28] qmp: Eliminate silly QERR_QMP_* macros, Markus Armbruster, 2017/03/03
- [Qemu-devel] [PATCH v4 18/28] test-qobject-input-visitor: Use strict visitor, Markus Armbruster, 2017/03/03
- [Qemu-devel] [PATCH v4 01/28] qga: Fix crash on non-dictionary QMP argument, Markus Armbruster, 2017/03/03
- [Qemu-devel] [PATCH v4 11/28] qapi: Improve a QObject input visitor error message, Markus Armbruster, 2017/03/03
- [Qemu-devel] [PATCH v4 06/28] qapi-introspect: Mangle --prefix argument properly for C, Markus Armbruster, 2017/03/03
- [Qemu-devel] [PATCH v4 04/28] qmp: Dumb down how we run QMP command registration, Markus Armbruster, 2017/03/03
- [Qemu-devel] [PATCH v4 12/28] qapi: Clean up after commit 3d344c2, Markus Armbruster, 2017/03/03
- [Qemu-devel] [PATCH v4 15/28] qapi: Drop string input visitor method optional(),
Markus Armbruster <=
- [Qemu-devel] [PATCH v4 27/28] qapi: Fix object input visit beyond end of list, Markus Armbruster, 2017/03/03
- [Qemu-devel] [PATCH v4 17/28] qom: Make object_property_set_qobject()'s input visitor strict, Markus Armbruster, 2017/03/03
- [Qemu-devel] [PATCH v4 26/28] tests: Cover input visit beyond end of list, Markus Armbruster, 2017/03/03
- [Qemu-devel] [PATCH v4 23/28] tests: Cover partial input visit of list, Markus Armbruster, 2017/03/03
- [Qemu-devel] [PATCH v4 25/28] qapi: Make input visitors detect unvisited list tails, Markus Armbruster, 2017/03/03
[Qemu-devel] [PATCH v4 24/28] test-qobject-input-visitor: Cover missing nested struct member, Markus Armbruster, 2017/03/03