qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 2/5] hw/intc/exynos4210_gic: Use more meaningful


From: Peter Maydell
Subject: Re: [Qemu-devel] [PATCH 2/5] hw/intc/exynos4210_gic: Use more meaningful name for local variable
Date: Thu, 2 Mar 2017 16:37:49 +0000

On 1 March 2017 at 18:26, Krzysztof Kozlowski <address@hidden> wrote:
> There are to SysBusDevice variables in exynos4210_gic_realize()
> function: one for the device itself and second for arm_gic device.  Add
> a prefix "gic" to the second one so it will be easier to understand the
> code.
>
> While at it, put local uninitialized 'i' variable at the end, next to
> other uninitialized ones.
>
> Signed-off-by: Krzysztof Kozlowski <address@hidden>
> ---
>  hw/intc/exynos4210_gic.c | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)

Reviewed-by: Peter Maydell <address@hidden>

thanks
-- PMM



reply via email to

[Prev in Thread] Current Thread [Next in Thread]