[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/2] ide: ahci: call cleanup function in ahci un
From: |
John Snow |
Subject: |
Re: [Qemu-devel] [PATCH 2/2] ide: ahci: call cleanup function in ahci unit |
Date: |
Tue, 28 Feb 2017 19:42:31 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 |
On 02/28/2017 07:35 PM, John Snow wrote:
>
>
> On 02/09/2017 02:04 AM, Li Qiang wrote:
>> This can avoid memory leak when hotunplug the ahci device.
>>
>> Signed-off-by: Li Qiang <address@hidden>
>> ---
>> hw/ide/ahci.c | 8 ++++++++
>> 1 file changed, 8 insertions(+)
>>
>> diff --git a/hw/ide/ahci.c b/hw/ide/ahci.c
>> index 3c19bda..56f68a8 100644
>> --- a/hw/ide/ahci.c
>> +++ b/hw/ide/ahci.c
>> @@ -1485,6 +1485,14 @@ void ahci_realize(AHCIState *s, DeviceState *qdev,
>> AddressSpace *as, int ports)
>>
>> void ahci_uninit(AHCIState *s)
>> {
>> + int i;
>> +
>> + for (i = 0; i < s->ports; i++) {
>> + AHCIDevice *ad = &s->dev[i];
>> +
>> + ide_unregister_restart_cb(&ad->port);
>> + ide_exit(&ad->port);
>> + }
>> g_free(s->dev);
>> }
>>
>>
>
> I couldn't actually prove to myself that ahci_uninit runs on an unplug
> request. Did you observe improvements to the memory profile after
> introducing this patch?
>
> I don't think anyone has taken the care to plumb AHCI to behave well
> when hotplugged.
>
Ah, my mistake actually! It's just that it requires guest cooperation.
It works perfectly well as long as Linux is ready to cooperate with the
request.
--js
Re: [Qemu-devel] [PATCH 1/2] ide: core: add cleanup function, John Snow, 2017/02/28
[Qemu-devel] [PATCH 2/2] ide: ahci: call cleanup function in ahci unit, Li Qiang, 2017/02/09