[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 24/26] tests: Cover input visit beyond end of
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v2 24/26] tests: Cover input visit beyond end of list |
Date: |
Tue, 28 Feb 2017 10:19:10 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 |
On 02/26/2017 03:43 PM, Markus Armbruster wrote:
> When you try to visit beyond the end of a list, the qobject input
> visitor crashes, and the string visitor screws returns garbage. The
> generated list visits never go beyond the list end, but manual visits
> could.
>
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
> tests/test-opts-visitor.c | 39
> ++++++++++++++++++++++++++++++++++++++
> tests/test-qobject-input-visitor.c | 10 ++++++++++
> tests/test-string-input-visitor.c | 16 ++++++++++++++++
> 3 files changed, 65 insertions(+)
>
>
> +static void
> +test_opts_range_beyond(void)
> +{
> +
> + /* Would be simpler if the visitor genuinely supported virtual walks */
> + visit_start_list(v, "ilist", (GenericList **)&list, sizeof(*list),
> + &error_abort);
> + tail = list;
> + visit_type_int(v, NULL, &tail->value, &error_abort);
> + g_assert_cmpint(tail->value, ==, 0);
> + tail = (intList *)visit_next_list(v, (GenericList *)tail, sizeof(*tail));
> + g_assert(!tail);
> + visit_type_int(v, NULL, &val, &err);
> + error_free_or_abort(&err);
> + visit_end_list(v, (void **)&list);
> +
Wow - something the opts visitor does better than the qobject visitor! Gasp!
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-devel] [PATCH v2 05/26] qmp: Clean up how we enforce capability negotiation, (continued)
- [Qemu-devel] [PATCH v2 15/26] qom: Make object_property_set_qobject()'s input visitor strict, Markus Armbruster, 2017/02/26
- [Qemu-devel] [PATCH v2 14/26] qapi: Make string input and opts visitor require non-null input, Markus Armbruster, 2017/02/26
- [Qemu-devel] [PATCH v2 03/26] qmp-test: New, covering basic QMP protocol, Markus Armbruster, 2017/02/26
- [Qemu-devel] [PATCH v2 07/26] qmp: Eliminate silly QERR_QMP_* macros, Markus Armbruster, 2017/02/26
- [Qemu-devel] [PATCH v2 21/26] tests: Cover partial input visit of list, Markus Armbruster, 2017/02/26
- [Qemu-devel] [PATCH v2 24/26] tests: Cover input visit beyond end of list, Markus Armbruster, 2017/02/26
- Re: [Qemu-devel] [PATCH v2 24/26] tests: Cover input visit beyond end of list,
Eric Blake <=
- [Qemu-devel] [PATCH v2 20/26] test-string-input-visitor: Improve list coverage, Markus Armbruster, 2017/02/26
- [Qemu-devel] [PATCH v2 17/26] qapi: Drop unused non-strict qobject input visitor, Markus Armbruster, 2017/02/26
- Re: [Qemu-devel] [PATCH v2 00/26] qapi: QMP dispatch and input visitor work, no-reply, 2017/02/26