[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 19/26] test-string-input-visitor: Tear down e
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH v2 19/26] test-string-input-visitor: Tear down existing test automatically |
Date: |
Tue, 28 Feb 2017 17:08:09 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) |
Eric Blake <address@hidden> writes:
> On 02/26/2017 03:43 PM, Markus Armbruster wrote:
>> Call visitor_input_teardown() from visitor_input_test_init(), so you
>> don't have to call it from the actial tests.
>
> s/actial/actual/
Will fix!
>>
>> Signed-off-by: Markus Armbruster <address@hidden>
>> ---
>> tests/test-string-input-visitor.c | 19 ++-----------------
>> 1 file changed, 2 insertions(+), 17 deletions(-)
>>
>
> Reviewed-by: Eric Blake <address@hidden>
>
> I tested this one under valgrind to ensure no weird memory issues
> cropped up, so you can also add:
>
> Tested-by: Eric Blake <address@hidden>
Thanks!
- Re: [Qemu-devel] [PATCH v2 02/26] libqtest: Work around a "QMP wants a newline" bug, (continued)
- [Qemu-devel] [PATCH v2 13/26] qapi: Drop string input visitor method optional(), Markus Armbruster, 2017/02/26
- [Qemu-devel] [PATCH v2 22/26] test-qobject-input-visitor: Cover missing nested struct member, Markus Armbruster, 2017/02/26
- [Qemu-devel] [PATCH v2 10/26] qapi: Clean up after commit 3d344c2, Markus Armbruster, 2017/02/26
- [Qemu-devel] [PATCH v2 04/26] qmp: Dumb down how we run QMP command registration, Markus Armbruster, 2017/02/26
- [Qemu-devel] [PATCH v2 19/26] test-string-input-visitor: Tear down existing test automatically, Markus Armbruster, 2017/02/26
- [Qemu-devel] [PATCH v2 12/26] qapi: Improve qobject input visitor error reporting, Markus Armbruster, 2017/02/26
- [Qemu-devel] [PATCH v2 23/26] qapi: Make input visitors detect unvisited list tails, Markus Armbruster, 2017/02/26
- [Qemu-devel] [PATCH v2 18/26] tests-qobject-input-strict: Merge into test-qobject-input-visitor, Markus Armbruster, 2017/02/26