Re: [Qemu-devel] [[PATCH-2]] Removed support for DEPTH!=32 in sm501.c

[Peter Maydell]

On 27 February 2017 at 16:01, Suramya Shah <address@hidden> wrote:
> Signed-off-by: Suramya Shah <address@hidden>
> ---
>  hw/display/sm501.c | 17 -----------------
>  1 file changed, 17 deletions(-)
>
> diff --git a/hw/display/sm501.c b/hw/display/sm501.c
> index 040a0b9..faca906 100644
> --- a/hw/display/sm501.c
> +++ b/hw/display/sm501.c
> @@ -1173,23 +1173,6 @@ typedef void draw_line_func(uint8_t *d, const uint8_t 
> *s,
>  typedef void draw_hwc_line_func(SM501State * s, int crt, uint8_t * palette,
>                                  int c_y, uint8_t *d, int width);
>
> -#define DEPTH 8
> -#include "sm501_template.h"
> -
> -#define DEPTH 15
> -#include "sm501_template.h"
> -
> -#define BGR_FORMAT
> -#define DEPTH 15
> -#include "sm501_template.h"
> -
> -#define DEPTH 16
> -#include "sm501_template.h"
> -
> -#define BGR_FORMAT
> -#define DEPTH 16
> -#include "sm501_template.h"
> -
>  #define DEPTH 32
>  #include "sm501_template.h"

Surely this code can't compile either? You've removed the definitions
of the draw_line8_8, draw_line8_15, etc functions but not their uses
later in this file.

I think you need to make sure that you have a setup that is compiling
the code changes that you make. Check that if you put an obvious
syntax error into the sm501.c file that it causes the build to fail.
(If it doesn't then you've probably not passed arguments to configure
to enable the sh4 target that uses this device.)

thanks
-- PMM