[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 12/30] tests: fix bios-tables-test leak
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH v2 12/30] tests: fix bios-tables-test leak |
Date: |
Mon, 27 Feb 2017 15:03:30 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) |
Marc-André Lureau <address@hidden> writes:
> The inside array should be free too.
> Spotted by ASAN.
>
> Signed-off-by: Marc-André Lureau <address@hidden>
> ---
> tests/bios-tables-test.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/bios-tables-test.c b/tests/bios-tables-test.c
> index 54048050c0..d54018da73 100644
> --- a/tests/bios-tables-test.c
> +++ b/tests/bios-tables-test.c
> @@ -144,7 +144,7 @@ static void free_test_data(test_data *data)
> g_free(temp->asl_file);
> }
>
> - g_array_free(data->tables, false);
> + g_array_free(data->tables, true);
> }
>
> static uint8_t acpi_checksum(const uint8_t *data, int len)
Reviewed-by: Markus Armbruster <address@hidden>
- [Qemu-devel] [PATCH v2 08/30] tests: fix q35-test leaks, (continued)
- [Qemu-devel] [PATCH v2 08/30] tests: fix q35-test leaks, Marc-André Lureau, 2017/02/21
- [Qemu-devel] [PATCH v2 07/30] tests: fix endianness-test leaks, Marc-André Lureau, 2017/02/21
- [Qemu-devel] [PATCH v2 09/30] tests: fix vhost-user-test leaks, Marc-André Lureau, 2017/02/21
- [Qemu-devel] [PATCH v2 10/30] tests: fix ide-test leaks, Marc-André Lureau, 2017/02/21
- [Qemu-devel] [PATCH v2 11/30] tests: fix hd-geo-test leaks, Marc-André Lureau, 2017/02/21
- [Qemu-devel] [PATCH v2 12/30] tests: fix bios-tables-test leak, Marc-André Lureau, 2017/02/21
- Re: [Qemu-devel] [PATCH v2 12/30] tests: fix bios-tables-test leak,
Markus Armbruster <=
- [Qemu-devel] [PATCH v2 14/30] tests: fix ipmi-bt-test leak, Marc-André Lureau, 2017/02/21
- [Qemu-devel] [PATCH v2 13/30] tests: fix ipmi-kcs-test leak, Marc-André Lureau, 2017/02/21
- [Qemu-devel] [PATCH v2 15/30] pc: pcihp: avoid adding ACPI_PCIHP_PROP_BSEL twice, Marc-André Lureau, 2017/02/21
- [Qemu-devel] [PATCH v2 16/30] tests: fix eepro100-test leak, Marc-André Lureau, 2017/02/21
- [Qemu-devel] [PATCH v2 17/30] tests: fix tco-test leaks, Marc-André Lureau, 2017/02/21
- [Qemu-devel] [PATCH v2 18/30] tests: fix e1000-test leak, Marc-André Lureau, 2017/02/21